From: Paolo Bonzini <pbonzini@redhat.com>
To: "Eduardo Habkost" <ehabkost@redhat.com>,
"Andreas Färber" <afaerber@suse.de>
Cc: libvir-list@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org,
Anthony Liguori <aliguori@amazon.com>,
Igor Mammedov <imammedo@redhat.com>,
Jiri Denemark <jdenemar@redhat.com>,
akong@redhat.com
Subject: Re: [Qemu-devel] CPU models and feature probing (was Re: [PATCH qom-cpu 00/16 v10] target-i386: convert CPU) features into properties
Date: Fri, 07 Feb 2014 11:55:25 +0100 [thread overview]
Message-ID: <52F4BB9D.60301@redhat.com> (raw)
In-Reply-To: <20140207101609.GF28427@otherpad.lan.raisama.net>
Il 07/02/2014 11:16, Eduardo Habkost ha scritto:
> You are not alone. I remember we spent lots of time trying to convince
> Anthony to allow global properties and compat_props affect dynamic
> properties not just static properties, and static properties were a big
> deal due to reasons I didn't understand completely. Now I am hearing the
> opposite message, and I don't understand the reasons for the change of
> plans. I am confused.
Picture me confused as well, but at the same I think I understand the
reasons for the change of plans.
At some point you have to acknowledge that the grand vision of QEMU as a
small core and management only poking at QOM objects with properties has
never materialized, and probably never will.
After seeing no progress whatsoever on
http://wiki.qemu.org/Features/QOM#TODO after 2 years, we should perhaps
try to get fresh ideas into QOM based on how we've been using it and
what we'd like to do with it. "Design by committee" (more accurately:
"design by prophet") will not lead us anywhere.
QOM definitely needs dynamic properties for child<>, and for tricks such
as simulation of array properties. However, assume Igor or Eduardo or
Marcel can come up with a new QAPI-friendly static properties design,
that combines the best feature of QOM dynamic properties and qdev static
properties, why should it be rejected?
Code should not be frozen against some abstract design, it must evolve
to solve concrete problems until it can solve all of them easily. Or do
we want to become a project where good code is not anymore the best way
to have other developers change their mind?
Paolo
next prev parent reply other threads:[~2014-02-07 10:55 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-27 22:28 [Qemu-devel] [PATCH qom-cpu 00/16 v10] target-i386: convert CPU features into properties Igor Mammedov
2013-11-27 22:28 ` [Qemu-devel] [PATCH 01/16] target-i386: cleanup 'foo' feature handling' Igor Mammedov
2013-11-27 22:28 ` [Qemu-devel] [PATCH 02/16] target-i386: cleanup 'foo=val' feature handling Igor Mammedov
2014-02-11 9:14 ` Eduardo Habkost
2014-02-11 14:28 ` Andreas Färber
2013-11-27 22:28 ` [Qemu-devel] [PATCH 03/16] target-i386: cpu: convert 'level' to static property Igor Mammedov
2014-02-11 9:14 ` Eduardo Habkost
2013-11-27 22:28 ` [Qemu-devel] [PATCH 04/16] target-i386: cpu: convert 'xlevel' " Igor Mammedov
2014-02-11 9:15 ` Eduardo Habkost
2013-11-27 22:28 ` [Qemu-devel] [PATCH 05/16] target-i386: cpu: convert 'family' " Igor Mammedov
2014-02-11 9:37 ` Eduardo Habkost
2013-11-27 22:28 ` [Qemu-devel] [PATCH 06/16] target-i386: cpu: convert 'model' " Igor Mammedov
2014-02-11 9:40 ` Eduardo Habkost
2013-11-27 22:28 ` [Qemu-devel] [PATCH 07/16] target-i386: cpu: convert 'stepping' " Igor Mammedov
2014-02-11 9:40 ` Eduardo Habkost
2013-11-27 22:28 ` [Qemu-devel] [PATCH 08/16] target-i386: cpu: convert 'vendor' " Igor Mammedov
2014-02-11 11:31 ` Eduardo Habkost
2013-11-27 22:28 ` [Qemu-devel] [PATCH 09/16] target-i386: cpu: convert 'model-id' " Igor Mammedov
2014-02-11 11:36 ` Eduardo Habkost
2013-11-27 22:28 ` [Qemu-devel] [PATCH 10/16] target-i386: cpu: convert 'tsc-frequency' " Igor Mammedov
2014-02-11 11:36 ` Eduardo Habkost
2013-11-27 22:28 ` [Qemu-devel] [PATCH 11/16] target-i386: set [+-]feature using static properties Igor Mammedov
2013-11-27 22:28 ` [Qemu-devel] [PATCH 12/16] qdev: introduce qdev_prop_find_bit() Igor Mammedov
2013-11-27 22:28 ` [Qemu-devel] [PATCH 13/16] target-i386: use static properties in check_features_against_host() to print CPUID feature names Igor Mammedov
2013-11-27 22:28 ` [Qemu-devel] [PATCH 14/16] target-i386: use static properties to list CPUID features Igor Mammedov
2013-11-27 22:28 ` [Qemu-devel] [PATCH 15/16] target-i386: remove unused *_feature_name arrays Igor Mammedov
2013-11-27 22:28 ` [Qemu-devel] [PATCH 16/16] target-i386: cpu: fix invalid use of error_is_set(errp) if errp == NULL Igor Mammedov
2013-12-15 22:50 ` [Qemu-devel] [PATCH qom-cpu 00/16 v10] target-i386: convert CPU features into properties Andreas Färber
2013-12-16 15:01 ` Igor Mammedov
2013-12-16 18:26 ` Eduardo Habkost
2013-12-17 13:01 ` Igor Mammedov
2014-01-07 8:41 ` Igor Mammedov
2014-02-05 14:40 ` Igor Mammedov
2014-02-05 16:14 ` Andreas Färber
2014-02-05 16:52 ` Igor Mammedov
2014-02-06 15:19 ` Igor Mammedov
2014-02-06 15:51 ` Andreas Färber
2014-02-06 16:16 ` [Qemu-devel] CPU models and feature probing (was Re: [PATCH qom-cpu 00/16 v10] target-i386: convert CPU) " Eduardo Habkost
2014-02-06 16:57 ` Andreas Färber
2014-02-07 10:16 ` Eduardo Habkost
2014-02-07 10:55 ` Paolo Bonzini [this message]
2014-02-11 11:54 ` Eduardo Habkost
2014-02-11 14:31 ` Anthony Liguori
2014-02-11 15:25 ` Eduardo Habkost
2014-02-11 15:58 ` Anthony Liguori
2014-02-11 16:43 ` Eduardo Habkost
2014-02-11 16:45 ` Paolo Bonzini
2014-02-11 16:55 ` Andreas Färber
2014-02-11 18:57 ` Anthony Liguori
2014-02-11 21:38 ` Paolo Bonzini
2014-02-07 10:37 ` Eduardo Habkost
2014-02-11 17:17 ` [Qemu-devel] [PATCH qom-cpu 00/16 v10] target-i386: convert CPU " Igor Mammedov
2014-03-05 16:53 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F4BB9D.60301@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=akong@redhat.com \
--cc=aliguori@amazon.com \
--cc=armbru@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=jdenemar@redhat.com \
--cc=libvir-list@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).