From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36255)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hdegoede@redhat.com>) id 1WBmZL-00043Y-1B
	for qemu-devel@nongnu.org; Fri, 07 Feb 2014 09:38:21 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <hdegoede@redhat.com>) id 1WBmZF-0000Rl-2p
	for qemu-devel@nongnu.org; Fri, 07 Feb 2014 09:38:14 -0500
Received: from mx1.redhat.com ([209.132.183.28]:1494)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hdegoede@redhat.com>) id 1WBmZE-0000Rb-RT
	for qemu-devel@nongnu.org; Fri, 07 Feb 2014 09:38:09 -0500
Received: from int-mx12.intmail.prod.int.phx2.redhat.com
	(int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s17Ec6o9027703
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 7 Feb 2014 09:38:07 -0500
Message-ID: <52F4EFCA.9020807@redhat.com>
Date: Fri, 07 Feb 2014 15:38:02 +0100
From: Hans de Goede <hdegoede@redhat.com>
MIME-Version: 1.0
References: <1391686923-11688-1-git-send-email-kraxel@redhat.com>
In-Reply-To: <1391686923-11688-1-git-send-email-kraxel@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/2] xhci iso: fix time calculation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org

Hi,

Looks good, ack series.

Regards,

Hans


On 02/06/2014 12:42 PM, Gerd Hoffmann wrote:
> Frameid specifies frames not microframes, so we
> need to shift it to get the microframe index.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>   hw/usb/hcd-xhci.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
> index 44964f4..2c54b86 100644
> --- a/hw/usb/hcd-xhci.c
> +++ b/hw/usb/hcd-xhci.c
> @@ -1974,8 +1974,8 @@ static void xhci_calc_iso_kick(XHCIState *xhci, XHCITransfer *xfer,
>               xfer->mfindex_kick = asap;
>           }
>       } else {
> -        xfer->mfindex_kick = (xfer->trbs[0].control >> TRB_TR_FRAMEID_SHIFT)
> -            & TRB_TR_FRAMEID_MASK;
> +        xfer->mfindex_kick = ((xfer->trbs[0].control >> TRB_TR_FRAMEID_SHIFT)
> +                              & TRB_TR_FRAMEID_MASK) << 3;
>           xfer->mfindex_kick |= mfindex & ~0x3fff;
>           if (xfer->mfindex_kick < mfindex) {
>               xfer->mfindex_kick += 0x4000;
>