From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60000) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WBoHY-0001h8-Cm for qemu-devel@nongnu.org; Fri, 07 Feb 2014 11:28:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WBoHT-00088l-HH for qemu-devel@nongnu.org; Fri, 07 Feb 2014 11:28:00 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58834) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WBoHT-00088d-7J for qemu-devel@nongnu.org; Fri, 07 Feb 2014 11:27:55 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s17GRs1s011876 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 7 Feb 2014 11:27:54 -0500 Message-ID: <52F50987.7030406@redhat.com> Date: Fri, 07 Feb 2014 09:27:51 -0700 From: Eric Blake MIME-Version: 1.0 References: <1391789578-19601-1-git-send-email-kwolf@redhat.com> <1391789578-19601-4-git-send-email-kwolf@redhat.com> In-Reply-To: <1391789578-19601-4-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="S1L5m1AV9qfjndbWQk6CqBXSnN7BIx3iJ" Subject: Re: [Qemu-devel] [PATCH 3/3] block: Don't call ROUND_UP with negative values List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-devel@nongnu.org Cc: lersek@redhat.com, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --S1L5m1AV9qfjndbWQk6CqBXSnN7BIx3iJ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02/07/2014 09:12 AM, Kevin Wolf wrote: > The behaviour of the ROUND_UP macro with negative numbers isn't obvious= =2E > It happens to do the right thing in this please, but better avoid it. s/please/place/ >=20 > Suggested-by: Laszlo Ersek > Signed-off-by: Kevin Wolf > --- > block.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Series: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --S1L5m1AV9qfjndbWQk6CqBXSnN7BIx3iJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJS9QmHAAoJEKeha0olJ0NquBEIAKSv41Hw80HFEpN/PtXP8C4O Vx5DK0pC2e1Z0C7HGwuvkYJ55+DwoBFTqZ8i+cdYGbhFz62Sz2dG25dGKUT/11C9 mrMGvoC9GlN5x+Ug2KQmlz1ob7Lr7Oj49vNFP4BJ5fTWsXtijkjKk6f3y6xJnmC7 9RFUT8zR5BCxmYLNb9WOXZ9YiPoco8PA2W0ZQt0WB9UWqRHkUD3NZYHb99ObVX6V dH4QNvfATjsslKGIowfjV5chvU8PJc7avAvONThR0nkd9XPX1OfH4UxqFs3dF+EJ De3kWak4I5+nGKX0SS0InUjD2rhlfDC+p2Q8AFlE+FvcRZFpowP5CgQkUcLEGm8= =6ICi -----END PGP SIGNATURE----- --S1L5m1AV9qfjndbWQk6CqBXSnN7BIx3iJ--