From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49881)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1WBumh-0001hO-43
	for qemu-devel@nongnu.org; Fri, 07 Feb 2014 18:24:41 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1WBumb-000685-4W
	for qemu-devel@nongnu.org; Fri, 07 Feb 2014 18:24:35 -0500
Received: from mx1.redhat.com ([209.132.183.28]:26120)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1WBuma-00067v-Sl
	for qemu-devel@nongnu.org; Fri, 07 Feb 2014 18:24:29 -0500
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s17NOQnI022285
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 7 Feb 2014 18:24:27 -0500
Message-ID: <52F56B28.3030600@redhat.com>
Date: Sat, 08 Feb 2014 00:24:24 +0100
From: Laszlo Ersek <lersek@redhat.com>
MIME-Version: 1.0
References: <1391789578-19601-1-git-send-email-kwolf@redhat.com>
	<1391789578-19601-4-git-send-email-kwolf@redhat.com>
	<52F50987.7030406@redhat.com>
	<20140207214537.GA3099@dhcp-200-207.str.redhat.com>
In-Reply-To: <20140207214537.GA3099@dhcp-200-207.str.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/3] block: Don't call ROUND_UP with
 negative values
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com

On 02/07/14 22:45, Kevin Wolf wrote:
> Am 07.02.2014 um 17:27 hat Eric Blake geschrieben:
>> On 02/07/2014 09:12 AM, Kevin Wolf wrote:
>>> The behaviour of the ROUND_UP macro with negative numbers isn't obvious.
>>> It happens to do the right thing in this please, but better avoid it.
>>
>> s/please/place/
> 
> Indeed... Thanks, fixed it locally.
> 
>>> Suggested-by: Laszlo Ersek <lersek@redhat.com>
>>> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
>>> ---
>>>  block.c | 4 ++--
>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> Series: Reviewed-by: Eric Blake <eblake@redhat.com>

Not necessary after Eric's review, but here it is anyway:

series
Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks!
Laszlo