From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55111) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WCHNT-0003Ok-O2 for qemu-devel@nongnu.org; Sat, 08 Feb 2014 18:32:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WCHNL-0003qT-AK for qemu-devel@nongnu.org; Sat, 08 Feb 2014 18:32:03 -0500 Received: from mail-ea0-x22e.google.com ([2a00:1450:4013:c01::22e]:35608) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WCHNL-0003qO-46 for qemu-devel@nongnu.org; Sat, 08 Feb 2014 18:31:55 -0500 Received: by mail-ea0-f174.google.com with SMTP id b10so2258177eae.33 for ; Sat, 08 Feb 2014 15:31:54 -0800 (PST) Sender: Paolo Bonzini Message-ID: <52F6BE62.6070503@redhat.com> Date: Sun, 09 Feb 2014 00:31:46 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1375478221-22722-1-git-send-email-afaerber@suse.de> <20130806084837.GA5268@igalia.com> <52F68C6B.2080908@suse.de> In-Reply-To: <52F68C6B.2080908@suse.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH qom-next for-next 0/6] QOM realize for IndustryPack List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-1?Q?Andreas_F=E4rber?= , Alberto Garcia Cc: Peter Maydell , "Michael S. Tsirkin" , qemu-devel@nongnu.org, Juan Quintela Il 08/02/2014 20:58, Andreas Färber ha scritto: > Patch 03/06 makes it obvious that the header should live somewhere in > include/ for documenting the base QOM type though. > > A minimally invasive alternative would be to move it from hw/char/ to > include/hw/char/ - would that be acceptable for everyone as first step? Ok. > The other issue was that while the ipoctal232 device is right in > hw/char/, tpci200.c and ipack.[hc] have nothing to do with char devices > - therefore this patch proposed hw/ipack/, matching drivers/ipack/ in Linux. It's okay, but I think I asked what other IPack modules exist and I had no answer. Paolo