From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50951) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WCOKm-0002eq-Cz for qemu-devel@nongnu.org; Sun, 09 Feb 2014 01:57:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WCOKa-0007Uy-QN for qemu-devel@nongnu.org; Sun, 09 Feb 2014 01:57:44 -0500 Received: from mail-ee0-x22a.google.com ([2a00:1450:4013:c00::22a]:41114) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WCOKa-0007Uq-Ix for qemu-devel@nongnu.org; Sun, 09 Feb 2014 01:57:32 -0500 Received: by mail-ee0-f42.google.com with SMTP id b15so2298437eek.1 for ; Sat, 08 Feb 2014 22:57:31 -0800 (PST) Sender: Paolo Bonzini Message-ID: <52F726D6.4090807@redhat.com> Date: Sun, 09 Feb 2014 07:57:26 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1391445551-6561-1-git-send-email-pbonzini@redhat.com> <1391445551-6561-17-git-send-email-pbonzini@redhat.com> <52F6695A.7090801@suse.de> <52F6BEB1.2090606@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL 16/16] target-i386: Move KVM default-vendor hack to instance_init List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Developers , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , Eduardo Habkost Il 09/02/2014 01:23, Peter Maydell ha scritto: > FWIW, we have just 39 files[*] which fail to follow the "declarations at > start of block" rule out of 2566, which is pretty good compliance for a > coding style rule which isn't enforced by technical means (I expect > it's much better than we achieve for "no hard tabs" or "braces on > all if statement arms", for instance). Ok, I just missed that and thought most people simply didn't like them. It would be nice to add that to CODING_STYLE, at least. Eduardo, can you make a patch to fix that? Paolo