From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33738)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WCTpE-00074L-UW
	for qemu-devel@nongnu.org; Sun, 09 Feb 2014 07:49:38 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WCTp5-00028N-5A
	for qemu-devel@nongnu.org; Sun, 09 Feb 2014 07:49:32 -0500
Received: from cantor2.suse.de ([195.135.220.15]:52738 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WCTp4-000289-VE
	for qemu-devel@nongnu.org; Sun, 09 Feb 2014 07:49:23 -0500
Message-ID: <52F7794D.7040302@suse.de>
Date: Sun, 09 Feb 2014 13:49:17 +0100
From: =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1391178886-17277-1-git-send-email-afaerber@suse.de>	<1391178886-17277-12-git-send-email-afaerber@suse.de>
	<CAEgOgz7m_m_kYKF_zqeiRyfPj-DjcxNAz5xU9vN9KhgLDA87Nw@mail.gmail.com>
In-Reply-To: <CAEgOgz7m_m_kYKF_zqeiRyfPj-DjcxNAz5xU9vN9KhgLDA87Nw@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 11/11] i2c: Drop FROM_I2C_SLAVE() macro
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>

Am 09.02.2014 02:53, schrieb Peter Crosthwaite:
> On Sat, Feb 1, 2014 at 12:34 AM, Andreas F=E4rber <afaerber@suse.de> wr=
ote:
>> Use type-specific QOM cast macros instead.
>>
>=20
> Should be past tense - "We now use type-specific ...". The imperative
> form of "use" suggests you are making the change in this patch but you
> have already done it.

It was meant as a guidance for resolving conflicts due to lack of that
macro, not as a description of past patches. I've adopted your wording.

>> Signed-off-by: Andreas F=E4rber <afaerber@suse.de>
>=20
> Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>

Thanks,
Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg