From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35899)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WCU3e-00037M-CF
	for qemu-devel@nongnu.org; Sun, 09 Feb 2014 08:04:31 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WCU3Y-0006F4-WE
	for qemu-devel@nongnu.org; Sun, 09 Feb 2014 08:04:26 -0500
Received: from cantor2.suse.de ([195.135.220.15]:53017 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WCU3Y-0006F0-Qf
	for qemu-devel@nongnu.org; Sun, 09 Feb 2014 08:04:20 -0500
Message-ID: <52F77CCF.2060807@suse.de>
Date: Sun, 09 Feb 2014 14:04:15 +0100
From: =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1391178886-17277-1-git-send-email-afaerber@suse.de>	<1391178886-17277-5-git-send-email-afaerber@suse.de>
	<CAEgOgz51LZ7Yk09e9yd2kdJYHWepEJJkPGVGz9irtO_ociM_jg@mail.gmail.com>
In-Reply-To: <CAEgOgz51LZ7Yk09e9yd2kdJYHWepEJJkPGVGz9irtO_ociM_jg@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 04/11] z2: QOM'ify AER915
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>

Am 09.02.2014 02:38, schrieb Peter Crosthwaite:
> On Sat, Feb 1, 2014 at 12:34 AM, Andreas F=E4rber <afaerber@suse.de> wr=
ote:
>> Replace usages of FROM_I2C_SLAVE() with QOM cast macro.
>>
>> Signed-off-by: Andreas F=E4rber <afaerber@suse.de>
>=20
> Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>

Thanks, adding and mentioning the following on top:

diff --git a/hw/arm/z2.c b/hw/arm/z2.c
index 69c4d38..67c1be8 100644
--- a/hw/arm/z2.c
+++ b/hw/arm/z2.c
@@ -357,7 +357,7 @@ static void z2_init(QEMUMachineInitArgs *args)
     type_register_static(&aer915_info);
     z2_lcd =3D ssi_create_slave(mpu->ssp[1], "zipit-lcd");
     bus =3D pxa2xx_i2c_bus(mpu->i2c[0]);
-    i2c_create_slave(bus, "aer915", 0x55);
+    i2c_create_slave(bus, TYPE_AER915, 0x55);
     wm =3D i2c_create_slave(bus, "wm8750", 0x1b);
     mpu->i2s->opaque =3D wm;
     mpu->i2s->codec_out =3D wm8750_dac_dat;

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg