From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55301)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mark.cave-ayland@ilande.co.uk>) id 1WCWH8-0003XQ-DK
	for qemu-devel@nongnu.org; Sun, 09 Feb 2014 10:26:37 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mark.cave-ayland@ilande.co.uk>) id 1WCWH0-00042L-WD
	for qemu-devel@nongnu.org; Sun, 09 Feb 2014 10:26:30 -0500
Received: from s16892447.onlinehome-server.info ([82.165.15.123]:44736)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mark.cave-ayland@ilande.co.uk>) id 1WCWH0-00042G-PS
	for qemu-devel@nongnu.org; Sun, 09 Feb 2014 10:26:22 -0500
Message-ID: <52F79DB2.1000401@ilande.co.uk>
Date: Sun, 09 Feb 2014 15:24:34 +0000
From: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
MIME-Version: 1.0
References: <1391877522-17254-1-git-send-email-mark.cave-ayland@ilande.co.uk>
	<1391877522-17254-2-git-send-email-mark.cave-ayland@ilande.co.uk>
	<52F79A4B.5060404@suse.de>
In-Reply-To: <52F79A4B.5060404@suse.de>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCHv2 1/2] sun4m: Add Sun CG3 framebuffer and
 corresponding OpenBIOS FCode ROM
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org, Blue Swirl <blauwirbel@gmail.com>, Bob Breuer <breuerr@mc.net>, Anthony Liguori <aliguori@amazon.com>, Paolo Bonzini <pbonzini@redhat.com>, Artyom Tarasenko <atar4qemu@gmail.com>

On 09/02/14 15:10, Andreas Färber wrote:

Hi Andreas,

> Hi,
>
> Am 08.02.2014 17:38, schrieb Mark Cave-Ayland:
>> +static Property cg3_properties[] = {
>> +    DEFINE_PROP_HEX32("vram_size",     CG3State, vram_size, -1),
>
> Paolo is about to drop hex32 ...

Hmmmm okay...

>> +    DEFINE_PROP_UINT16("width",        CG3State, width,     -1),
>> +    DEFINE_PROP_UINT16("height",       CG3State, height,    -1),
>> +    DEFINE_PROP_UINT16("depth",        CG3State, depth,     -1),
>> +    DEFINE_PROP_HEX64("prom_addr",     CG3State, prom_addr, -1),
>
> ...and hex64 types. Please use UINT32 and UINT64 instead.

Alright I can change those for the next version of the patch. Does that 
mean the use of hex output is now a display option rather than a 
separate property type?

>> +    DEFINE_PROP_END_OF_LIST(),
>> +};
>
> And as far as QOM and style is concerned, please don't use TCX as excuse
> to do things the old way. If you feel you need consistency, feel free to
> clean up TCX, but we only require it for new patches. Otherwise no
> progress would be possible within the code base.

Okay, I understand this. I'm highly tempted to submit a clean-up patch 
for TCX too when this is complete just to keep both drivers in a similar 
state.

One thing I'm not sure about is how the QOM stuff interacts with sysbus 
- can you quickly point me towards an existing device that does this so 
I can understand how this works? These patches have been around for 
months and I really want to get them in for QEMU 2.0 if freeze is coming 
up soon.


Many thanks,

Mark.