Re: [Qemu-devel] [PATCHv2 1/2] sun4m: Add Sun CG3 framebuffer and corresponding OpenBIOS FCode ROM

["Andreas Färber" <afaerber@suse.de>]

Am 09.02.2014 16:24, schrieb Mark Cave-Ayland:
> One thing I'm not sure about is how the QOM stuff interacts with sysbus
> - can you quickly point me towards an existing device that does this so
> I can understand how this works?

The ARM MPCore devices come to mind. But really all you've been asked to
do in that aspect is replace dc->init with dc->realize and adapt the
signature to make it compile. :) A bonus would be to separate between
.instance_init and dc->realize, with MemoryRegion initialization and
anything that does not rely on properties going into the initfn, and
everything relying on properties being specified or affecting global
state (such as RAM registration, VMState registration, ...) going into
the realizefn.

> These patches have been around for
> months and I really want to get them in for QEMU 2.0 if freeze is coming
> up soon.

Apart from Blue's absence I see no major blocker to that. :)

I initially wondered if -vga wasn't considered a legacy option, but I
figured we can't create SysBus/SBus devices through -device, so no
alternative. SBus QOM base class refactorings as discussed for an
earlier device can be applied on top and are not strictly needed for 2.0
unless you have more such devices coming up.

Cheers,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg