From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57726) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WCmDt-0001oa-HC for qemu-devel@nongnu.org; Mon, 10 Feb 2014 03:28:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WCmDm-0005dV-Be for qemu-devel@nongnu.org; Mon, 10 Feb 2014 03:28:13 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56362) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WCmDm-0005dK-3c for qemu-devel@nongnu.org; Mon, 10 Feb 2014 03:28:06 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s1A8S5ww026172 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 10 Feb 2014 03:28:05 -0500 Message-ID: <52F88D90.9070109@redhat.com> Date: Mon, 10 Feb 2014 09:28:00 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1391939335-31580-1-git-send-email-pbonzini@redhat.com> <1391939335-31580-10-git-send-email-pbonzini@redhat.com> <20140210080453.GK15707@T430.nay.redhat.com> In-Reply-To: <20140210080453.GK15707@T430.nay.redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 09/20] cow: correctly propagate errors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, mreitz@redhat.com Il 10/02/2014 09:04, Fam Zheng ha scritto: > I'm never sure about choice of using local_err with error_propagate, or > straightly pass errp, but the logic still looks right to me, so, Basically, never use error_is_set. If you do, you probably should have used instead &local_err and error_propagate. If you are not using error_is_set, it's fine to use errp directly with no error_propagate. Paolo > Reviewed-by: Fam Zheng