From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35309) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WCmkj-00068H-04 for qemu-devel@nongnu.org; Mon, 10 Feb 2014 04:02:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WCmka-0005iU-Hv for qemu-devel@nongnu.org; Mon, 10 Feb 2014 04:02:08 -0500 Received: from mail-ea0-x234.google.com ([2a00:1450:4013:c01::234]:64293) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WCmka-0005iQ-1v for qemu-devel@nongnu.org; Mon, 10 Feb 2014 04:02:00 -0500 Received: by mail-ea0-f180.google.com with SMTP id o10so2839142eaj.11 for ; Mon, 10 Feb 2014 01:01:59 -0800 (PST) Sender: Paolo Bonzini Message-ID: <52F89580.1080608@redhat.com> Date: Mon, 10 Feb 2014 10:01:52 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1391939335-31580-1-git-send-email-pbonzini@redhat.com> <1391939335-31580-20-git-send-email-pbonzini@redhat.com> <20140210084722.GU15707@T430.nay.redhat.com> In-Reply-To: <20140210084722.GU15707@T430.nay.redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 19/20] block: do not abuse EMEDIUMTYPE List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, mreitz@redhat.com Il 10/02/2014 09:47, Fam Zheng ha scritto: >> > @@ -449,7 +449,7 @@ static int qcow2_open(BlockDriverState *bs, QDict *options, int flags, >> > >> > if (header.magic != QCOW_MAGIC) { >> > error_setg(errp, "Image is not in qcow2 format"); > It might be good to have a consistent message pattern in qcow2 as others. Right, I'll fix the others. > Is it worth adding a QERR_ error class for unexpected format magic? We're not adding QERR_ anymore, but if anyone has ideas I can do something to improve the homogeneity of the errors. Paolo