From: Eric Blake <eblake@redhat.com>
To: "Lluís Vilanova" <vilanova@ac.upc.edu>, qemu-devel@nongnu.org
Cc: Markus Armbruster <armbru@redhat.com>,
Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 1/2] qapi: Use an explicit input file
Date: Mon, 10 Feb 2014 13:10:29 -0700 [thread overview]
Message-ID: <52F93235.8070102@redhat.com> (raw)
In-Reply-To: <20140210195823.3495.6520.stgit@fimbulvetr.bsc.es>
[-- Attachment #1: Type: text/plain, Size: 815 bytes --]
On 02/10/2014 12:58 PM, Lluís Vilanova wrote:
> Use an explicit input file on the command-line instead of reading from standard input
>
> Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>Summary:
Screwed up S-o-b line, but the maintainer can probably fix that without
needing a respin.
> ---
> Makefile | 24 ++++++++++++++++++------
> scripts/qapi-commands.py | 10 +++++++---
> scripts/qapi-types.py | 9 ++++++---
> scripts/qapi-visit.py | 9 ++++++---
> scripts/qapi.py | 4 ++--
> tests/Makefile | 12 +++++++++---
> 6 files changed, 48 insertions(+), 20 deletions(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2014-02-10 20:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-10 19:58 [Qemu-devel] [PATCH v2 0/2] qapi: Allow modularization of QAPI schema files Lluís Vilanova
2014-02-10 19:58 ` [Qemu-devel] [PATCH v2 1/2] qapi: Use an explicit input file Lluís Vilanova
2014-02-10 20:10 ` Eric Blake [this message]
2014-02-10 19:58 ` [Qemu-devel] [PATCH v2 2/2] qapi: Add a primitive to include other files from a QAPI schema file Lluís Vilanova
2014-02-10 20:30 ` Eric Blake
2014-02-11 8:40 ` [Qemu-devel] [PATCH v2 0/2] qapi: Allow modularization of QAPI schema files Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F93235.8070102@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=vilanova@ac.upc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).