From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53051)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1WCxGn-0007aU-4E
	for qemu-devel@nongnu.org; Mon, 10 Feb 2014 15:16:02 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1WCxGg-0002br-QJ
	for qemu-devel@nongnu.org; Mon, 10 Feb 2014 15:15:57 -0500
Received: from mail-qa0-x233.google.com ([2607:f8b0:400d:c00::233]:53229)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1WCxGg-0002bd-Lz
	for qemu-devel@nongnu.org; Mon, 10 Feb 2014 15:15:50 -0500
Received: by mail-qa0-f51.google.com with SMTP id f11so10222906qae.38
	for <qemu-devel@nongnu.org>; Mon, 10 Feb 2014 12:15:50 -0800 (PST)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <52F93371.1010507@twiddle.net>
Date: Mon, 10 Feb 2014 12:15:45 -0800
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1391809763-11251-1-git-send-email-peter.maydell@linaro.org>
In-Reply-To: <1391809763-11251-1-git-send-email-peter.maydell@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 0/8] A64: Neon support, fourth set
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Peter Crosthwaite <peter.crosthwaite@xilinx.com>, patches@linaro.org, Michael Matz <matz@suse.de>, Alexander Graf <agraf@suse.de>, Claudio Fontana <claudio.fontana@linaro.org>, Dirk Mueller <dmueller@suse.de>, Will Newton <will.newton@linaro.org>, Laurent Desnogues <laurent.desnogues@gmail.com>, =?UTF-8?B?QWxleCBCZW5uw6ll?= <alex.bennee@linaro.org>, kvmarm@lists.cs.columbia.edu, Christoffer Dall <christoffer.dall@linaro.org>

On 02/07/2014 01:49 PM, Peter Maydell wrote:
> This is the fourth set of A64 Neon support patches. This set
> provides complete implementations of the categories:
>  * scalar x indexed
>  * vector x indexed
>  * scalar three-different
> and fills in all the previously missing instructions in:
>  * vector 3-reg-same
>  * scalar 3-reg-same
> 
> It includes adding support in softfloat for "fused multiply,
> add and then divide by two", because the A64 VRECPS instruction
> requires it.
> 
> By my reckoning the parts that are still missing for Neon are:
>  * parts of scalar shift-immediate and vector shift-immediate
>  * parts of scalar-2-misc
>  * most of vector-3-diff
>  * parts of vector-2-misc

Except for the nit in 7/8,

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~