[Qemu-devel] qmp_* functions into 'kvm-all.c'

[Qemu-devel] qmp_* functions into 'kvm-all.c'

[Vincent KHERBACHE]

Hi all,

I just created a new QMP command following the
'writing-qmp-commands.txt' howto.

It's works well by adding the corresponding function into 'qmp.c', but
when I want to insert the function in 'kvm-all.c' (which is my goal) I
get an 'undefined reference' error to the function from 'qmp-marchal.c'
during the compilation.

I already included "qmp-commands.h" in 'kvm-all.c' preprocessor but it
didn't solve the problem.


Does someone know how to fix it (or why it happens) ?
Thanks.


Regards,
-- 
Vincent KHERBACHE
PhD Student at INRIA Sophia (FRANCE)

Re: [Qemu-devel] qmp_* functions into 'kvm-all.c'

[Andreas Färber]

Hi,

Am 10.02.2014 19:18, schrieb Vincent KHERBACHE:
> I just created a new QMP command following the
> 'writing-qmp-commands.txt' howto.
> 
> It's works well by adding the corresponding function into 'qmp.c', but
> when I want to insert the function in 'kvm-all.c' (which is my goal) I
> get an 'undefined reference' error to the function from 'qmp-marchal.c'
> during the compilation.

Have you thought of also adding a corresponding function to kvm-stub.c
for the targets not linking kvm-all.c?

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

Re: [Qemu-devel] qmp_* functions into 'kvm-all.c'

[Vincent KHERBACHE]

That's right !

Problem solved by adding the stub function to 'kvm-stub.c'.

Thank you very much !


Le 10/02/2014 20:45, Andreas Färber a écrit :
> Hi,
> 
> Am 10.02.2014 19:18, schrieb Vincent KHERBACHE:
>> I just created a new QMP command following the
>> 'writing-qmp-commands.txt' howto.
>>
>> It's works well by adding the corresponding function into 'qmp.c', but
>> when I want to insert the function in 'kvm-all.c' (which is my goal) I
>> get an 'undefined reference' error to the function from 'qmp-marchal.c'
>> during the compilation.
> 
> Have you thought of also adding a corresponding function to kvm-stub.c
> for the targets not linking kvm-all.c?
> 
> Regards,
> Andreas
> 

-- 
Vincent KHERBACHE

Re: [Qemu-devel] qmp_* functions into 'kvm-all.c'

[Paolo Bonzini]

Il 10/02/2014 19:18, Vincent KHERBACHE ha scritto:
>
> I just created a new QMP command following the
> 'writing-qmp-commands.txt' howto.
>
> It's works well by adding the corresponding function into 'qmp.c', but
> when I want to insert the function in 'kvm-all.c' (which is my goal) I
> get an 'undefined reference' error to the function from 'qmp-marchal.c'
> during the compilation.
>
> I already included "qmp-commands.h" in 'kvm-all.c' preprocessor but it
> didn't solve the problem.
>
>
> Does someone know how to fix it (or why it happens) ?
> Thanks.

Maybe you need to add a dummy implementation in kvm-stub.c?  kvm-all.c 
is not compiled into all targets, only on the "native" ones (e.g. i386 
and x86_64 if compiling on x86).

Paolo