From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49914) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WCytK-0005Kz-JL for qemu-devel@nongnu.org; Mon, 10 Feb 2014 16:59:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WCytB-0006cy-Kb for qemu-devel@nongnu.org; Mon, 10 Feb 2014 16:59:50 -0500 Received: from mail-ee0-x22f.google.com ([2a00:1450:4013:c00::22f]:52565) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WCytB-0006cs-CB for qemu-devel@nongnu.org; Mon, 10 Feb 2014 16:59:41 -0500 Received: by mail-ee0-f47.google.com with SMTP id d49so3226219eek.34 for ; Mon, 10 Feb 2014 13:59:40 -0800 (PST) Sender: Paolo Bonzini Message-ID: <52F94BC8.8090602@redhat.com> Date: Mon, 10 Feb 2014 22:59:36 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <52F917FB.40101@inria.fr> In-Reply-To: <52F917FB.40101@inria.fr> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] qmp_* functions into 'kvm-all.c' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vincent KHERBACHE , qemu-devel@nongnu.org Il 10/02/2014 19:18, Vincent KHERBACHE ha scritto: > > I just created a new QMP command following the > 'writing-qmp-commands.txt' howto. > > It's works well by adding the corresponding function into 'qmp.c', but > when I want to insert the function in 'kvm-all.c' (which is my goal) I > get an 'undefined reference' error to the function from 'qmp-marchal.c' > during the compilation. > > I already included "qmp-commands.h" in 'kvm-all.c' preprocessor but it > didn't solve the problem. > > > Does someone know how to fix it (or why it happens) ? > Thanks. Maybe you need to add a dummy implementation in kvm-stub.c? kvm-all.c is not compiled into all targets, only on the "native" ones (e.g. i386 and x86_64 if compiling on x86). Paolo