From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39942) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WCzyX-0001M4-3f for qemu-devel@nongnu.org; Mon, 10 Feb 2014 18:09:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WCzyS-0001QU-HP for qemu-devel@nongnu.org; Mon, 10 Feb 2014 18:09:17 -0500 Received: from mail-ee0-x230.google.com ([2a00:1450:4013:c00::230]:37044) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WCzyS-0001QL-BP for qemu-devel@nongnu.org; Mon, 10 Feb 2014 18:09:12 -0500 Received: by mail-ee0-f48.google.com with SMTP id t10so3219644eei.35 for ; Mon, 10 Feb 2014 15:09:11 -0800 (PST) Sender: Paolo Bonzini Message-ID: <52F95C12.4000404@redhat.com> Date: Tue, 11 Feb 2014 00:09:06 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1390890126-17377-1-git-send-email-qiaonuohan@cn.fujitsu.com> <1390890126-17377-14-git-send-email-qiaonuohan@cn.fujitsu.com> <20140210141048.796e9c91@redhat.com> <52F94C84.20105@redhat.com> In-Reply-To: <52F94C84.20105@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v8 13/13] dump: add 'query-dump-guest-memory-capability' command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek , Luiz Capitulino Cc: stefanha@gmail.com, qemu-devel@nongnu.org, qiaonuohan , kumagai-atsushi@mxc.nes.nec.co.jp, anderson@redhat.com, afaerber@suse.de Il 10/02/2014 23:02, Laszlo Ersek ha scritto: > On 02/10/14 20:10, Luiz Capitulino wrote: >> On Tue, 28 Jan 2014 14:22:06 +0800 >> qiaonuohan wrote: >> >>> 'query-dump-guest-memory-capability' is used to query whether option 'format' >>> is available for 'dump-guest-memory' and the available format. The output >>> of the command will be like: >>> >>> -> { "execute": "query-dump-guest-memory-capability" } >>> <- { "return": { >>> "format-option": "optional", >>> "capabilities": [ >>> {"available": true, "format": "elf"}, >>> {"available": true, "format": "kdump-zlib"}, >>> {"available": true, "format": "kdump-lzo"}, >>> {"available": true, "format": "kdump-snappy"} >>> ] >>> } >> >> I don't want to hold this series anymore, this series is long and I know it >> took you and Laszlo's a long time to get it right. On the other hand we can't >> allow every single command to have its own introspection protocol. >> >> I think I'm fine accepting this one now, as long as it's fine for libvirt >> too. Eric, can you confirm this please? > > We discussed this before, and Eric participated. In fact the custom > introspection was one of his recommendations. > > http://thread.gmane.org/gmane.comp.emulators.qemu/221270/focus=246650 > > (Which I agreed with because it would give us the most independence.) > > Of course I'm not trying to imply that this one specific interface will > doubtlessly serve all of libvirt's needs wrt. the kdump feature. We > certainly need Eric to sign off on that. I think the justification here is that even if you defined an Enum for ['elf','kdump-zlib', 'kdump-lzo', 'kdump-snappy'], it would not be enough to describe which values were compiled in (as opposed to supported by the particular QEMU version). However, I don't see the point in having the "format-option" field. What about: -> { "execute": "query-dump-guest-memory-formats" } <- { "return": [ {"available": true, "name": "elf"}, {"available": true, "name": "kdump-zlib"}, {"available": true, "name": "kdump-lzo"}, {"available": true, "name": "kdump-snappy"} ] or just <- { "return": ["elf", "kdump-zlib", "kdump-lzo", "kdump-snappy"] } ? Paolo