[Qemu-devel] question about patch "send the gratuitous by guest"

[Qemu-devel] question about patch "send the gratuitous by guest"

[Huangweidong (C)]

[-- Attachment #1: Type: text/plain, Size: 517 bytes --]

Hi,
    I found the network was broken after migrating the vm, the same as you said in "Send the
gratuitous by guest".The vm modify the mac of network card.IN the scenario with
vlan the network was broken too.
    The guest driver of virtio-net in linux kernel 3.10 has included the feature
which your patch refer to. But qemu has not included the feature. I want to use your
patch to resolve this problem. Could you give me some advice? And what's the plan about next version?
Thanks.


Best Regards!



[-- Attachment #2: Type: text/html, Size: 4394 bytes --]

Re: [Qemu-devel] question about patch "send the gratuitous by guest"

[Jason Wang]

On 02/11/2014 03:43 PM, Huangweidong (C) wrote:
>
> Hi,
>
> I found the network was broken after migrating the vm, the same as you
> said in "Send the
>
> gratuitous by guest".The vm modify the mac of network card.IN the
> scenario with
>
> vlan the network was broken too.
>
> The guest driver of virtio-net in linux kernel 3.10 has included the
> feature
>
> which your patch refer to. But qemu has not included the feature. I
> want to use your
>
> patch to resolve this problem. Could you give me some advice? And
> what’s the plan about next version?
>
> Thanks.
>
> Best Regards!
>

I'm not sure whether or not it's easy to rebase my old series. Or you
can wait for few days for me to post the new version.

Thanks

[Qemu-devel] 答复: question about patch "send the gratuitous by guest"

[Huangweidong (C)]

Glad to see your serial patch soon!

THX.

-----邮件原件-----
发件人: Jason Wang [mailto:jasowang@redhat.com] 
发送时间: 2014年2月11日 16:23
收件人: Huangweidong (C)
抄送: chenliang (T); qemu-devel@nongnu.org
主题: Re: question about patch "send the gratuitous by guest"

On 02/11/2014 03:43 PM, Huangweidong (C) wrote:
>
> Hi,
>
> I found the network was broken after migrating the vm, the same as you 
> said in "Send the
>
> gratuitous by guest".The vm modify the mac of network card.IN the 
> scenario with
>
> vlan the network was broken too.
>
> The guest driver of virtio-net in linux kernel 3.10 has included the 
> feature
>
> which your patch refer to. But qemu has not included the feature. I 
> want to use your
>
> patch to resolve this problem. Could you give me some advice? And 
> what’s the plan about next version?
>
> Thanks.
>
> Best Regards!
>

I'm not sure whether or not it's easy to rebase my old series. Or you can wait for few days for me to post the new version.

Thanks

Re: [Qemu-devel] question about patch "send the gratuitous by guest"

[Weidong Huang]

Hi，

after testing your patch,the guest will send arp packet when it
configure vlan or alias on the virtio net.

But bridge or bond do not send arp. what's your opinion?

BTW,this feature need modify the driver of virtio net.

Only the newest linux kernel support it. So what's about old guest os?

Thanks.


On 2014/2/11 16:22, Jason Wang wrote:
> On 02/11/2014 03:43 PM, Huangweidong (C) wrote:
>> Hi,
>>
>> I found the network was broken after migrating the vm, the same as you
>> said in "Send the
>>
>> gratuitous by guest".The vm modify the mac of network card.IN the
>> scenario with
>>
>> vlan the network was broken too.
>>
>> The guest driver of virtio-net in linux kernel 3.10 has included the
>> feature
>>
>> which your patch refer to. But qemu has not included the feature. I
>> want to use your
>>
>> patch to resolve this problem. Could you give me some advice? And
>> what’s the plan about next version?
>>
>> Thanks.
>>
>> Best Regards!
>>
> I'm not sure whether or not it's easy to rebase my old series. Or you
> can wait for few days for me to post the new version.
>
> Thanks
>
>

Re: [Qemu-devel] question about patch "send the gratuitous by guest"

[Jason Wang]

On 02/15/2014 11:01 AM, Weidong Huang wrote:
> it
> configure vlan or alias on the virtio net.
>
> But bridge or bond do not send arp. what's your opinion?

Do you mean bridge or bond in guest?
>
> BTW,this feature need modify the driver of virtio net.
>
> Only the newest linux kernel support it. So what's about old guest os?
>

It will be hard for the legacy device to know about migration. One
workaround is:

- enable arp_notify
- toggle link status after migration

> Thanks.

Re: [Qemu-devel] question about patch "send the gratuitous by guest"

[Weidong Huang]

On 2014/2/18 10:48, Jason Wang wrote:

> On 02/15/2014 11:01 AM, Weidong Huang wrote:
>> it
>> configure vlan or alias on the virtio net.
>>
>> But bridge or bond do not send arp. what's your opinion?
> 
> Do you mean bridge or bond in guest?

yes.

>>
>> BTW,this feature need modify the driver of virtio net.
>>
>> Only the newest linux kernel support it. So what's about old guest os?
>>
> 
> It will be hard for the legacy device to know about migration. One
> workaround is:
> 
> - enable arp_notify
> - toggle link status after migration
> 
>> Thanks.
> 
> 
> 

Re: [Qemu-devel] question about patch "send the gratuitous by guest"

[Jason Wang]

On 02/18/2014 12:25 PM, Weidong Huang wrote:
> On 2014/2/18 10:48, Jason Wang wrote:
>
>> > On 02/15/2014 11:01 AM, Weidong Huang wrote:
>>> >> it
>>> >> configure vlan or alias on the virtio net.
>>> >>
>>> >> But bridge or bond do not send arp. what's your opinion?
>> > 
>> > Do you mean bridge or bond in guest?
> yes.
>

I'm not quite understand the issue.

For bonding, doesn't it depend on the mac address of lower device to
work? Btw, it's a little strange to use bonding in guest, since you may
lose the falilover function because there's no MII support for
virtio-net or emulated card.

For bridge, the questions is the same.

So, it should work, if garp was sent by lower devices?

Thanks