From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45641) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WDDAd-0007Co-Bm for qemu-devel@nongnu.org; Tue, 11 Feb 2014 08:14:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WDDAY-0002yS-ST for qemu-devel@nongnu.org; Tue, 11 Feb 2014 08:14:39 -0500 Received: from mx1.redhat.com ([209.132.183.28]:7587) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WDDAY-0002yJ-BK for qemu-devel@nongnu.org; Tue, 11 Feb 2014 08:14:34 -0500 Message-ID: <52FA2236.2080006@redhat.com> Date: Tue, 11 Feb 2014 06:14:30 -0700 From: Eric Blake MIME-Version: 1.0 References: <20140210161600.4f9b34a1@redhat.com> <52F94654.8080401@redhat.com> <87vbwmt5gu.fsf@blackfin.pond.sub.org> In-Reply-To: <87vbwmt5gu.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="MOK0I7gTsw6PFtet9B0JWM0LgXsnKcgk9" Subject: Re: [Qemu-devel] [PATCH v3] qmp: expose list of supported character device backends List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Martin Kletzander , qemu-devel@nongnu.org, Anthony Liguori , Luiz Capitulino This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --MOK0I7gTsw6PFtet9B0JWM0LgXsnKcgk9 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02/11/2014 01:32 AM, Markus Armbruster wrote: > Eric Blake writes: >> >> Hmm, right now, the ChardevBackend union pre-dates when we added flat >> unions. For flat unions, we can set a discriminator to be an enum typ= e >> [1], at which point the code generator then validates that we cover al= l >> values of the enum in branches of the union; maybe it's worth >> retro-fitting simple unions to also take advantage of the additional >> coverage of the discriminator being an enum. >=20 > Yes, and Wenchao Xia has been working towards that: "[PATCH V5 00/10] > qapi script: support enum as discriminator and better enum name". >=20 >> [1] actually, did those patches ever get applied, and we just missed >> documenting it in qapi-code-gen.txt, or are they still pending review?= >=20 > By "those", do you mean Wenchao Xia's patches? Maybe my [1] to tie together two widely separated paragraphs wasn't obvious, but yes, I meant Wenchao's tests. Plus they just got reposted: https://lists.gnu.org/archive/html/qemu-devel/2014-02/msg01706.html --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --MOK0I7gTsw6PFtet9B0JWM0LgXsnKcgk9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJS+iI3AAoJEKeha0olJ0NqqV4IAJrgh7v2tgFfEPGWkjE8J62w Y6Mw+iFOQ7IpECM5QgfVG/aMBvZJTwPFqMB2Byq9Hk0f+whgMtjAe3EgtUGTw5PM jroqUt8JZoz5kh1EVrXD2eey4D4lyxPuD3Ax30EHyTr0YDgzOSysL/BBeDttUTAM w9Q81/RilCv1GFrElIP3ofMTlin7A9Cr7OzUiNFxiGAgoQQV6Jr028xM9omI3uAp V6mK+EMoarBjvnbOSFDR+95pCyC5PUaC7iItLXyY99iUCi05h/72f2UPNx0t38uT MbiTFRmsVvSWOTs7jeXqB8rc0lnGyCzCzehgLf7ltvAffMX/etfPVDtlYfrsrLY= =2212 -----END PGP SIGNATURE----- --MOK0I7gTsw6PFtet9B0JWM0LgXsnKcgk9--