From: Eric Blake <eblake@redhat.com>
To: Hu Tao <hutao@cn.fujitsu.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Stefan Hajnoczi <stefanha@gmail.com>, Fam Zheng <famz@redhat.com>,
Peter Lieven <pl@kamp.de>
Subject: Re: [Qemu-devel] [PATCH v5 RESEND 1/4] qapi: introduce PreallocMode and a new PreallocMode full.
Date: Tue, 11 Feb 2014 06:20:03 -0700 [thread overview]
Message-ID: <52FA2383.90005@redhat.com> (raw)
In-Reply-To: <ffd8b3ee42e8fd815cde27afa5d25f173e25f897.1392102900.git.hutao@cn.fujitsu.com>
[-- Attachment #1: Type: text/plain, Size: 959 bytes --]
On 02/11/2014 12:07 AM, Hu Tao wrote:
> This patch prepares for the subsequent patches.
>
> Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>
> ---
> block/qcow2.c | 8 ++++----
> qapi-schema.json | 12 ++++++++++++
> 2 files changed, 16 insertions(+), 4 deletions(-)
> +++ b/qapi-schema.json
> @@ -4419,3 +4419,15 @@
> # Since: 1.7
> ##
> { 'command': 'blockdev-add', 'data': { 'options': 'BlockdevOptions' } }
> +
> +##
> +# @PreallocMode
> +#
> +# Preallocation mode of QEMU image file
> +#
> +# @off: no preallocation
> +# @metadata: preallocate only for metadata
> +# @full: preallocate all data, including metadata
Missing a line:
# Since 2.0
> +##
> +{ 'enum': 'PreallocMode',
> + 'data': [ 'off', 'metadata', 'full' ] }
>
With that fixed, you can add:
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2014-02-11 13:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-11 7:07 [Qemu-devel] [PATCH v5 RESEND 0/4] qemu-img: add preallocation=full Hu Tao
2014-02-11 7:07 ` [Qemu-devel] [PATCH v5 RESEND 1/4] qapi: introduce PreallocMode and a new PreallocMode full Hu Tao
2014-02-11 8:56 ` Fam Zheng
2014-02-11 13:20 ` Eric Blake [this message]
2014-02-12 1:36 ` Hu Tao
2014-02-11 7:07 ` [Qemu-devel] [PATCH v5 RESEND 2/4] raw, qcow2: don't convert file size to sector size Hu Tao
2014-02-11 8:53 ` Fam Zheng
2014-02-12 1:35 ` Hu Tao
2014-02-11 7:07 ` [Qemu-devel] [PATCH v5 RESEND 3/4] raw-posix: Add full image preallocation option Hu Tao
2014-02-11 9:04 ` Fam Zheng
2014-02-12 1:53 ` Hu Tao
2014-02-11 7:07 ` [Qemu-devel] [PATCH v5 RESEND 4/4] qcow2: " Hu Tao
2014-02-25 5:11 ` Hu Tao
2014-02-27 14:09 ` [Qemu-devel] [PATCH v5 RESEND 0/4] qemu-img: add preallocation=full Stefan Hajnoczi
2014-02-28 1:19 ` Hu Tao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FA2383.90005@redhat.com \
--to=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=hutao@cn.fujitsu.com \
--cc=kwolf@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).