From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46566)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1WDDGI-0003ai-En
	for qemu-devel@nongnu.org; Tue, 11 Feb 2014 08:20:36 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1WDDGE-00051j-7O
	for qemu-devel@nongnu.org; Tue, 11 Feb 2014 08:20:30 -0500
Received: from mx1.redhat.com ([209.132.183.28]:23951)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1WDDGD-00051V-Uu
	for qemu-devel@nongnu.org; Tue, 11 Feb 2014 08:20:26 -0500
Message-ID: <52FA2383.90005@redhat.com>
Date: Tue, 11 Feb 2014 06:20:03 -0700
From: Eric Blake <eblake@redhat.com>
MIME-Version: 1.0
References: <cover.1392102900.git.hutao@cn.fujitsu.com>
	<ffd8b3ee42e8fd815cde27afa5d25f173e25f897.1392102900.git.hutao@cn.fujitsu.com>
In-Reply-To: <ffd8b3ee42e8fd815cde27afa5d25f173e25f897.1392102900.git.hutao@cn.fujitsu.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="NG942SkerWEKn015B38rLcWWMpeuUU35q"
Subject: Re: [Qemu-devel] [PATCH v5 RESEND 1/4] qapi: introduce PreallocMode
 and a new PreallocMode full.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Hu Tao <hutao@cn.fujitsu.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@gmail.com>, Fam Zheng <famz@redhat.com>, Peter Lieven <pl@kamp.de>

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--NG942SkerWEKn015B38rLcWWMpeuUU35q
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 02/11/2014 12:07 AM, Hu Tao wrote:
> This patch prepares for the subsequent patches.
>=20
> Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>
> ---
>  block/qcow2.c    |  8 ++++----
>  qapi-schema.json | 12 ++++++++++++
>  2 files changed, 16 insertions(+), 4 deletions(-)

> +++ b/qapi-schema.json
> @@ -4419,3 +4419,15 @@
>  # Since: 1.7
>  ##
>  { 'command': 'blockdev-add', 'data': { 'options': 'BlockdevOptions' } =
}
> +
> +##
> +# @PreallocMode
> +#
> +# Preallocation mode of QEMU image file
> +#
> +# @off: no preallocation
> +# @metadata: preallocate only for metadata
> +# @full: preallocate all data, including metadata

Missing a line:
# Since 2.0

> +##
> +{ 'enum': 'PreallocMode',
> +  'data': [ 'off', 'metadata', 'full' ] }
>=20

With that fixed, you can add:
Reviewed-by: Eric Blake <eblake@redhat.com>

--=20
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--NG942SkerWEKn015B38rLcWWMpeuUU35q
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJS+iODAAoJEKeha0olJ0NqIrsH/jXOWMzOHlRBG2kPXBmH2dFR
du7cu4DLnOxY258GVrmQRV6nI7MnWIYDU+Z0rEdCaLFi2g6aaodIsfL+nIHUQYTj
hwd6lAutVMBwo9yTkxELK/mHBfDHfgDxMwo2WYSC71mF1wfFg5YfDmRXQ7yfbPdF
zQbWm9RxkohfKUZMgAsGLnkhPm7iwQhLX2aMBxysytj4TaT8VaFtR6a0//U8EfXj
d4WbK+WULCTwkFjBxvn8c/ersFCFD0x9453HwFAIox4rWBmLixfmGe5/8fd8cvUN
A4qrW2pKbY0LR5v4D5MQzi9Gqm5LncQBVMFnKwxzhRmLRgfzRGXRLVwDWMkczOc=
=6OVU
-----END PGP SIGNATURE-----

--NG942SkerWEKn015B38rLcWWMpeuUU35q--