From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48033) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WDDM2-0005Rg-C2 for qemu-devel@nongnu.org; Tue, 11 Feb 2014 08:26:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WDDLx-0006qq-GE for qemu-devel@nongnu.org; Tue, 11 Feb 2014 08:26:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49090) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WDDLx-0006qi-7m for qemu-devel@nongnu.org; Tue, 11 Feb 2014 08:26:21 -0500 Message-ID: <52FA24F1.20408@redhat.com> Date: Tue, 11 Feb 2014 06:26:09 -0700 From: Eric Blake MIME-Version: 1.0 References: <1390890126-17377-1-git-send-email-qiaonuohan@cn.fujitsu.com> <1390890126-17377-14-git-send-email-qiaonuohan@cn.fujitsu.com> <20140210141048.796e9c91@redhat.com> <52F94C84.20105@redhat.com> <52F95C46.3030701@redhat.com> <52F9611D.7000808@redhat.com> <52F9620D.5040204@redhat.com> <20140210214721.2df300e4@redhat.com> <52F9CF10.50806@redhat.com> In-Reply-To: <52F9CF10.50806@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="PggBfVTC3h9q2Q0SO5cBnpqivwfS8Ot7O" Subject: Re: [Qemu-devel] [PATCH v8 13/13] dump: add 'query-dump-guest-memory-capability' command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , Luiz Capitulino Cc: stefanha@gmail.com, qemu-devel@nongnu.org, qiaonuohan , kumagai-atsushi@mxc.nes.nec.co.jp, anderson@redhat.com, Laszlo Ersek , afaerber@suse.de This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --PggBfVTC3h9q2Q0SO5cBnpqivwfS8Ot7O Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02/11/2014 12:19 AM, Paolo Bonzini wrote: > Il 11/02/2014 03:47, Luiz Capitulino ha scritto: >> On Tue, 11 Feb 2014 00:34:37 +0100 >> Paolo Bonzini wrote: >> >>> Il 11/02/2014 00:30, Laszlo Ersek ha scritto: >>>>>> However, I don't see the point in having the "format-option" >>>>>> field. What >>>>>> about: >>>>>> >>>>>> -> { "execute": "query-dump-guest-memory-capabilities" } >>>>>> <- { "return": { "formats": >>>>>> ["elf", "kdump-zlib", "kdump-lzo", "kdump-snappy"] } >>>> Technically you might be right. However, this partial introspection >>>> feature is entirely a wart >> Yes, I can. But what's the problem with patch 13? For me having Eric's= >> ACK is enough for applying it. Anything else will be done by QMP >> introspection. >=20 > I'm suggesting another, more streamlined format; see above. I like Paolo's suggestion of a more streamlined format. With migration introspection, we could do two things - learn the set of knobs available (query-migrate-capabilities), AND change those knobs (migrate-set-capabilities). Thus, each knob had to be listed as a struct that showed both the name of the knob and the current status. But here, we are not changing the set of format options on the fly. The simpler array of string names supported is sufficient; it's less work for libvirt to get an array of strings than it is to get an array of structs only to then determine the name from the struct and the redundant boolean that all such names are supported. =46rom libvirt's perspective, I think patch 13/13 needs to be respun into= the simpler format. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --PggBfVTC3h9q2Q0SO5cBnpqivwfS8Ot7O Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJS+iTxAAoJEKeha0olJ0NqXc0H/jOWXklkvc5so9NolZCogl93 yeq1km9B96IELiMJZK29LGkG5Pia3VNqyhKwuKx/eoHBp6NzCEd/aqWi8lZmG2AC 0HQwBhaEiqIqZHiA93wo9o950lgj4aHxr3SN9CKsCswUcilGggwlBtVCaywmxq4H U7kpAOm3iwPsXa9GUnGRw4ahbtCuj1zPkpewfvlRV9H2rvKMpYXVqVNO0d7xaSI/ ycBtOvJCERUqEqgNlZfArFlmqvfo5z2p9m4nuSBJ3nQb65YZfZlLcZiG6l08EVpw wYkM8R+bA1ZDTVt4O0ZMu7i+NHy85GRtso25fUmD19SC8VnwIRNUJNwlCtzduk0= =VW0c -----END PGP SIGNATURE----- --PggBfVTC3h9q2Q0SO5cBnpqivwfS8Ot7O--