From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60693) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WDEKB-0002JE-S9 for qemu-devel@nongnu.org; Tue, 11 Feb 2014 09:28:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WDEK6-0008Bo-13 for qemu-devel@nongnu.org; Tue, 11 Feb 2014 09:28:35 -0500 Received: from cantor2.suse.de ([195.135.220.15]:36956 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WDEK5-0008Bb-Qa for qemu-devel@nongnu.org; Tue, 11 Feb 2014 09:28:29 -0500 Message-ID: <52FA3388.307@suse.de> Date: Tue, 11 Feb 2014 15:28:24 +0100 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1385591336-2755-1-git-send-email-imammedo@redhat.com> <1385591336-2755-3-git-send-email-imammedo@redhat.com> <20140211091417.GQ24353@otherpad.lan.raisama.net> In-Reply-To: <20140211091417.GQ24353@otherpad.lan.raisama.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 02/16] target-i386: cleanup 'foo=val' feature handling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: Igor Mammedov , qemu-devel@nongnu.org Am 11.02.2014 10:14, schrieb Eduardo Habkost: > On Wed, Nov 27, 2013 at 11:28:42PM +0100, Igor Mammedov wrote: >> features family, model, stepping, level, hv_spinlocks are treated simi= larly >> when passed from command line, so it's not necessary to handle each of= them >> individually. Collapse them to one catch-all branch which will treat >> any not explicitly handled feature in format 'foo=3Dval'. >> >> PS: >> Any unknown feature will be rejected by property setter so there is no >> need to check for unknown feature in cpu_x86_parse_featurestr(), there= fore >> it's replaced by above mentioned catch-all handler. >> >> Signed-off-by: Igor Mammedov >=20 > Reviewed-by: Eduardo Habkost Too late: http://git.qemu.org/?p=3Dqemu.git;a=3Dcommit;h=3Dd024d209045b912eb6127861= fab2af6c64880efd Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg