From: Richard Henderson <rth@twiddle.net>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: patches@linaro.org, "Michael Matz" <matz@suse.de>,
"Alexander Graf" <agraf@suse.de>,
"Claudio Fontana" <claudio.fontana@linaro.org>,
"Dirk Mueller" <dmueller@suse.de>,
"Will Newton" <will.newton@linaro.org>,
"Laurent Desnogues" <laurent.desnogues@gmail.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
kvmarm@lists.cs.columbia.edu,
"Christoffer Dall" <christoffer.dall@linaro.org>
Subject: Re: [Qemu-devel] [PATCH v2 2/2] target-arm: A64: Implement remaining 3-same instructions
Date: Tue, 11 Feb 2014 07:40:16 -0800 [thread overview]
Message-ID: <52FA4460.6030809@twiddle.net> (raw)
In-Reply-To: <1392126679-18461-3-git-send-email-peter.maydell@linaro.org>
On 02/11/2014 05:51 AM, Peter Maydell wrote:
> @@ -2376,7 +2376,7 @@ float32 float32_muladd(float32 a, float32 b, float32 c, int flags STATUS_PARAM)
> if (cExp == 0) {
> normalizeFloat32Subnormal(cSig, &cExp, &cSig);
> }
> - cExp--;
> + cExp -= 2;
> cSig = (cSig | 0x00800000) << 7;
> return roundAndPackFloat32(cSign ^ signflip, cExp, cSig STATUS_VAR);
> }
> @@ -4107,7 +4107,7 @@ float64 float64_muladd(float64 a, float64 b, float64 c, int flags STATUS_PARAM)
> if (cExp == 0) {
> normalizeFloat64Subnormal(cSig, &cExp, &cSig);
> }
> - cExp--;
> + cExp -= 2;
> cSig = (cSig | 0x0010000000000000ULL) << 10;
> return roundAndPackFloat64(cSign ^ signflip, cExp, cSig STATUS_VAR);
> }
This should obviously be folded into the previous patch.
Probably with a comment reminding about roundAndPackFloat wanting an off-by-one
exponent.
Otherwise both get
Reviewed-by: Richard Henderson <rth@twiddle.net>
r~
next prev parent reply other threads:[~2014-02-11 15:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-11 13:51 [Qemu-devel] [PATCH v2 0/2] A64: Neon support, fourth set Peter Maydell
2014-02-11 13:51 ` [Qemu-devel] [PATCH v2 1/2] softfloat: Support halving the result of muladd operation Peter Maydell
2014-02-11 13:51 ` [Qemu-devel] [PATCH v2 2/2] target-arm: A64: Implement remaining 3-same instructions Peter Maydell
2014-02-11 15:40 ` Richard Henderson [this message]
2014-02-11 15:55 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FA4460.6030809@twiddle.net \
--to=rth@twiddle.net \
--cc=agraf@suse.de \
--cc=alex.bennee@linaro.org \
--cc=christoffer.dall@linaro.org \
--cc=claudio.fontana@linaro.org \
--cc=dmueller@suse.de \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=laurent.desnogues@gmail.com \
--cc=matz@suse.de \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=will.newton@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).