From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50245)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1WDFRk-000252-JF
	for qemu-devel@nongnu.org; Tue, 11 Feb 2014 10:40:34 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1WDFRe-0006Gc-3z
	for qemu-devel@nongnu.org; Tue, 11 Feb 2014 10:40:28 -0500
Received: from mail-qa0-x229.google.com ([2607:f8b0:400d:c00::229]:58673)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1WDFRe-0006GT-0M
	for qemu-devel@nongnu.org; Tue, 11 Feb 2014 10:40:22 -0500
Received: by mail-qa0-f41.google.com with SMTP id w8so11982441qac.14
	for <qemu-devel@nongnu.org>; Tue, 11 Feb 2014 07:40:21 -0800 (PST)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <52FA4460.6030809@twiddle.net>
Date: Tue, 11 Feb 2014 07:40:16 -0800
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1392126679-18461-1-git-send-email-peter.maydell@linaro.org>
	<1392126679-18461-3-git-send-email-peter.maydell@linaro.org>
In-Reply-To: <1392126679-18461-3-git-send-email-peter.maydell@linaro.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 2/2] target-arm: A64: Implement
	remaining 3-same instructions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: patches@linaro.org, Michael Matz <matz@suse.de>, Alexander Graf <agraf@suse.de>, Claudio Fontana <claudio.fontana@linaro.org>, Dirk Mueller <dmueller@suse.de>, Will Newton <will.newton@linaro.org>, Laurent Desnogues <laurent.desnogues@gmail.com>, =?ISO-8859-1?Q?Alex_Benn=E9e?= <alex.bennee@linaro.org>, kvmarm@lists.cs.columbia.edu, Christoffer Dall <christoffer.dall@linaro.org>

On 02/11/2014 05:51 AM, Peter Maydell wrote:
> @@ -2376,7 +2376,7 @@ float32 float32_muladd(float32 a, float32 b, float32 c, int flags STATUS_PARAM)
>              if (cExp == 0) {
>                  normalizeFloat32Subnormal(cSig, &cExp, &cSig);
>              }
> -            cExp--;
> +            cExp -= 2;
>              cSig = (cSig | 0x00800000) << 7;
>              return roundAndPackFloat32(cSign ^ signflip, cExp, cSig STATUS_VAR);
>          }
> @@ -4107,7 +4107,7 @@ float64 float64_muladd(float64 a, float64 b, float64 c, int flags STATUS_PARAM)
>              if (cExp == 0) {
>                  normalizeFloat64Subnormal(cSig, &cExp, &cSig);
>              }
> -            cExp--;
> +            cExp -= 2;
>              cSig = (cSig | 0x0010000000000000ULL) << 10;
>              return roundAndPackFloat64(cSign ^ signflip, cExp, cSig STATUS_VAR);
>          }

This should obviously be folded into the previous patch.

Probably with a comment reminding about roundAndPackFloat wanting an off-by-one
exponent.

Otherwise both get

Reviewed-by: Richard Henderson <rth@twiddle.net>



r~