Re: [Qemu-devel] [PATCH v2] QMP: Allow dot separated dict path arguments in qmp-shell

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1112 bytes --]

On 02/11/2014 06:22 PM, Fam Zheng wrote:
> As another convinience to allow using commands that expect a dict as

s/convinience/convenience/

> argument, this patch adds support for foo.bar=value syntax, similar to
> command line argument style:
> 
>   (QEMU) blockdev-add options.driver=file options.id=drive1 options.filename=...
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>

> +                if type(d) is not dict:
> +                    raise QMPShellError('Can not use "%s" as both leaf and non-leaf key' % '.'.join(curpath))

s/Can not/Cannot/

> +                parent[p] = d
> +                parent = d
> +            if optpath[-1] in parent:
> +                if type(parent[optpath[-1]]) is dict:
> +                    raise QMPShellError('Can not use "%s" as both leaf and non-leaf key' % '.'.join(curpath))
> +                else:
> +                    raise QMPShellError('Can not set "%s" for multiple times' % opt[0])

twice more.  Also, s/for //

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]