From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51525) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WDQW4-0006gC-Kg for qemu-devel@nongnu.org; Tue, 11 Feb 2014 22:29:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WDQW0-0008K9-Ct for qemu-devel@nongnu.org; Tue, 11 Feb 2014 22:29:40 -0500 Received: from mx1.redhat.com ([209.132.183.28]:10108) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WDQW0-0008K5-56 for qemu-devel@nongnu.org; Tue, 11 Feb 2014 22:29:36 -0500 Message-ID: <52FAEA8B.7080500@redhat.com> Date: Tue, 11 Feb 2014 20:29:15 -0700 From: Eric Blake MIME-Version: 1.0 References: <1390890126-17377-1-git-send-email-qiaonuohan@cn.fujitsu.com> <1390890126-17377-14-git-send-email-qiaonuohan@cn.fujitsu.com> <20140210141048.796e9c91@redhat.com> <52F94C84.20105@redhat.com> <52F95C46.3030701@redhat.com> <52F9611D.7000808@redhat.com> <52F9620D.5040204@redhat.com> <20140210214721.2df300e4@redhat.com> <52F9CF10.50806@redhat.com> <52FA24F1.20408@redhat.com> <52FAE6E2.8050703@cn.fujitsu.com> In-Reply-To: <52FAE6E2.8050703@cn.fujitsu.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ewFKq5Adsc7jOMaorfGeGkQ5aaNPitSqa" Subject: Re: [Qemu-devel] [PATCH v9 13/13] dump: add 'query-dump-guest-memory-capability' command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Qiao Nuohan , Paolo Bonzini , Luiz Capitulino , Laszlo Ersek Cc: stefanha@gmail.com, kumagai-atsushi@mxc.nes.nec.co.jp, qemu-devel@nongnu.org, afaerber@suse.de, anderson@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ewFKq5Adsc7jOMaorfGeGkQ5aaNPitSqa Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02/11/2014 08:13 PM, Qiao Nuohan wrote: > 'query-dump-guest-memory-capability' is used to query the available > formats of > 'dump-guest-memory'. The output of the command will be like: >=20 > -> { "execute": "query-dump-guest-memory-capability" } > <- { "return": { "formats": > ["elf", "kdump-zlib", "kdump-lzo", "kdump-snappy"] = } >=20 > Signed-off-by: Qiao Nuohan > --- > dump.c | 33 +++++++++++++++++++++++++++++++++ > qapi-schema.json | 9 +++++++++ > qmp-commands.hx | 23 +++++++++++++++++++++++ > 3 files changed, 65 insertions(+), 0 deletions(-) > +++ b/qapi-schema.json > @@ -2783,6 +2783,15 @@ > '*length': 'int', '*format': 'DumpGuestMemoryFormat' } } >=20 > ## > +# Since: 2.0 A bit sparse on the documentation; at a minimum, you want a line: # @query-dump-guest-memory-capability: prior to the Since designation (look at @query-name for an example). > + > +SQMP > +query-dump-guest-memory-capability > +---------- > + > +Show available format of 'dump-guest-memory' s/format of/formats for/ > + > +Example: > + > +-> { "execute": "query-dump-guest-memory-capability" } > +<- { "return": { "formats": > + ["elf", "kdump-zlib", "kdump-lzo", "kdump-snappy"]= } > + > +Note: This is a light-weight introspection to let management know the > available > + formats of dump-guest-memory. This note feels a bit redundant with the earlier summary; I'm okay if you leave it in, but I also don't mind if you drop it. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --ewFKq5Adsc7jOMaorfGeGkQ5aaNPitSqa Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJS+uqLAAoJEKeha0olJ0NqfisH/Atk09XoLLoLkYxx79g1XQJ1 Df/ejIbYaHWCsE7PsZqQznluGjGuMniL09xfQsC8UrITpAhMyxodi9/DE8uqnlRC Y2LcwYFXg8kW+gSHgDyQVHpWZKxqDShgXA5Ftcdv2N0g427+r6OtwLoqdlddayU3 Jh1fZW/GP0fZUe18PzU7ko7707q/XxsUxMfv9KZ98RBXNsmehtRexdqr+pl+lTsp fXTG7jCW6Qd7QkAkHZKWQeg5edIVDSz+/tow0Bp4ACbogPe19Z+0V2KYQsTdybl2 GeytFHkGbo4VMDivfPKhMIpGB0hTLHGOyYwzuxBf/vMdwmLOVxxrOvZ7xU6rxmw= =Ne1D -----END PGP SIGNATURE----- --ewFKq5Adsc7jOMaorfGeGkQ5aaNPitSqa--