From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45670) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WDfpq-0004q7-OW for qemu-devel@nongnu.org; Wed, 12 Feb 2014 14:51:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WDfpl-0007O6-T7 for qemu-devel@nongnu.org; Wed, 12 Feb 2014 14:51:06 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40677) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WDfpl-0007Nj-JI for qemu-devel@nongnu.org; Wed, 12 Feb 2014 14:51:01 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s1CJp03A001713 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 12 Feb 2014 14:51:00 -0500 Message-ID: <52FBD0A3.9080204@redhat.com> Date: Wed, 12 Feb 2014 12:50:59 -0700 From: Eric Blake MIME-Version: 1.0 References: <3196de212da6d9fd5f93cce7d0ae276e8e1795b0.1392234236.git.jcody@redhat.com> In-Reply-To: <3196de212da6d9fd5f93cce7d0ae276e8e1795b0.1392234236.git.jcody@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="FX0iCQ9civIUfkjga8I3GVPRsPdukEpMl" Subject: Re: [Qemu-devel] [PATCH] block: Don't throw away errno via error_setg List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeff Cody , qemu-devel@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --FX0iCQ9civIUfkjga8I3GVPRsPdukEpMl Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02/12/2014 12:46 PM, Jeff Cody wrote: > There are a handful of places in the block layer where a failure path > has a valid -errno value, yet error_setg() is used. Those instances > should instead use error_setg_errno(), to preserve as much error > information as possible. >=20 > This patch replaces those instances with error_setg_errno(), so that > errno is passed up the stack in the error message. >=20 > Reported-By: Kevin Wolf > Signed-off-by: Jeff Cody > --- > block/mirror.c | 13 +++++++++---- > block/qcow2-snapshot.c | 8 +++++--- > block/vmdk.c | 6 +++--- > 3 files changed, 17 insertions(+), 10 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --FX0iCQ9civIUfkjga8I3GVPRsPdukEpMl Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJS+9CjAAoJEKeha0olJ0NqkpgIAICDohcywKo7F/6ouGA5+fZ8 /LBt09NqvVbqMZ67qGuSU671FaRlz651rpMeMmh/CYjXaS7PkDE2eVmACj3tn1EU OorzZv6OmtfrP8Q5qHuZEJQf9NHwY6mvCVz1p2AOL1BGFq+C72Ub9WBoeDm+Tbl8 i1OjJr/xv88Vn4is4hQ1Kg6ICK+ZStDk4WZ9xZ6dfubXBvNB091MPDw0wE4aQFDu G3dhlxY8MEz0ew4SxhUm5eZEh/JM6nxF73yS/Qxb+WKAchOj//ZgF1JVmqWgMPot b9aIp25qY1sMDzg6ui2MzPUhjiNxgrmo9mjomDH531CvQgr92hj1ZXocbe4VzL8= =7+ve -----END PGP SIGNATURE----- --FX0iCQ9civIUfkjga8I3GVPRsPdukEpMl--