From: Eric Blake <eblake@redhat.com>
To: Amos Kong <akong@redhat.com>, qemu-devel@nongnu.org
Cc: jyang@redhat.com, laine@redhat.com, libvir-list@redhat.com,
armbru@redhat.com, rjones@redhat.com, anthony@codemonkey.ws,
pbonzini@redhat.com, lcapitulino@redhat.com
Subject: Re: [Qemu-devel] [PATCH 2/5] introduce two marcos to dump the options info
Date: Wed, 12 Feb 2014 13:37:21 -0700 [thread overview]
Message-ID: <52FBDB81.6020403@redhat.com> (raw)
In-Reply-To: <1390881230-14033-3-git-send-email-akong@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 723 bytes --]
On 01/27/2014 08:53 PM, Amos Kong wrote:
s/marcos/macros/ in the subject line
> We will use the marocs to generate two tables, which contain
s/marocs/macros/
(wow, two different ways to mis-spell the word)
> the option name and argument information.
>
> Signed-off-by: Amos Kong <akong@redhat.com>
> ---
> qemu-options-wrapper.h | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
although I'd probably squash this with the patch that actually defines
QEMU_OPTIONS_GENERATE_{NAME,HASARG}, as this patch is useless on its own.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2014-02-12 20:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-28 3:53 [Qemu-devel] [PATCH 0/5] fix query-command-line-options Amos Kong
2014-01-28 3:53 ` [Qemu-devel] [PATCH 1/5] qmp: rename query_option_descs() to get_param_infolist() Amos Kong
2014-02-12 20:33 ` Eric Blake
2014-01-28 3:53 ` [Qemu-devel] [PATCH 2/5] introduce two marcos to dump the options info Amos Kong
2014-02-11 10:55 ` Markus Armbruster
2014-02-12 20:37 ` Eric Blake [this message]
2014-01-28 3:53 ` [Qemu-devel] [PATCH 3/5] query-command-line-options: query all the options in qemu-options.hx Amos Kong
2014-02-11 12:03 ` Markus Armbruster
2014-02-17 8:26 ` Amos Kong
2014-02-12 20:39 ` Eric Blake
2014-01-28 3:53 ` [Qemu-devel] [PATCH 4/5] introduce QEMU_OPTIONS_GENERATE_HELPMSG Amos Kong
2014-02-11 12:03 ` Markus Armbruster
2014-02-12 20:41 ` Eric Blake
2014-01-28 3:53 ` [Qemu-devel] [PATCH 5/5] query-command-line-options: return help message for legacy options Amos Kong
2014-02-11 12:19 ` Markus Armbruster
2014-02-12 20:48 ` Eric Blake
2014-02-17 8:49 ` Amos Kong
2014-02-12 21:00 ` Eric Blake
2014-02-17 8:56 ` Amos Kong
2014-02-10 20:26 ` [Qemu-devel] [PATCH 0/5] fix query-command-line-options Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FBDB81.6020403@redhat.com \
--to=eblake@redhat.com \
--cc=akong@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=armbru@redhat.com \
--cc=jyang@redhat.com \
--cc=laine@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=libvir-list@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).