From: Eric Blake <eblake@redhat.com>
To: Chunyan Liu <cyliu@suse.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, Dong Xu Wang <wdongxu@linux.vnet.ibm.com>,
stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH v20 02/26] qapi: output def_value_str when query command line options
Date: Wed, 12 Feb 2014 16:05:28 -0700 [thread overview]
Message-ID: <52FBFE38.4070900@redhat.com> (raw)
In-Reply-To: <1392186806-10418-3-git-send-email-cyliu@suse.com>
[-- Attachment #1: Type: text/plain, Size: 838 bytes --]
On 02/11/2014 11:33 PM, Chunyan Liu wrote:
> Change qapi interfaces to output the newly added def_value_str when query
s/query/querying/
> command line options.
>
> Signed-off-by: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
> Signed-off-by: Chunyan Liu <cyliu@suse.com>
> ---
> +++ b/qapi-schema.json
> @@ -3930,12 +3930,16 @@
> #
> # @help: #optional human readable text string, not suitable for parsing.
> #
> -# Since 1.5
> +# @default: #optional string representation of the default used
> +# if the option is omitted.
> +#
> +# Since 1.6
Changing the Since line is wrong. The @default line needs a "(since
2.0)" designation added.
But the schema addition itself is appropriate.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2014-02-12 23:06 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-12 6:33 [Qemu-devel] [PATCH v20 00/26] replace QEMUOptionParameter with QemuOpts Chunyan Liu
2014-02-12 6:33 ` [Qemu-devel] [PATCH v20 01/26] add def_value_str to QemuOptDesc Chunyan Liu
2014-02-12 23:00 ` Eric Blake
2014-02-18 7:06 ` Chunyan Liu
2014-02-12 6:33 ` [Qemu-devel] [PATCH v20 02/26] qapi: output def_value_str when query command line options Chunyan Liu
2014-02-12 23:05 ` Eric Blake [this message]
2014-02-12 6:33 ` [Qemu-devel] [PATCH v20 03/26] improve some functions in qemu-option.c Chunyan Liu
2014-02-12 23:22 ` Eric Blake
2014-02-18 6:28 ` Chunyan Liu
2014-02-12 6:33 ` [Qemu-devel] [PATCH v20 04/26] add some QemuOpts functions for replace work Chunyan Liu
2014-02-12 23:31 ` Eric Blake
2014-02-18 6:43 ` Chunyan Liu
2014-02-12 6:33 ` [Qemu-devel] [PATCH v20 05/26] remove assertion of qemu_opt_get functions Chunyan Liu
2014-02-12 23:50 ` Eric Blake
2014-02-12 6:33 ` [Qemu-devel] [PATCH v20 06/26] change block layer to support both QemuOpts and QEMUOptionParameter Chunyan Liu
2014-02-13 0:12 ` Eric Blake
2014-02-18 6:44 ` Chunyan Liu
2014-02-12 6:33 ` [Qemu-devel] [PATCH v20 07/26] cow.c: replace QEMUOptionParameter with QemuOpts Chunyan Liu
2014-02-13 0:19 ` Eric Blake
2014-02-18 7:15 ` Chunyan Liu
2014-02-12 6:33 ` [Qemu-devel] [PATCH v20 08/26] gluster.c: " Chunyan Liu
2014-02-13 0:21 ` Eric Blake
2014-02-12 6:33 ` [Qemu-devel] [PATCH v20 09/26] iscsi.c: " Chunyan Liu
2014-02-13 0:22 ` Eric Blake
2014-02-12 6:33 ` [Qemu-devel] [PATCH v20 10/26] qcow.c: " Chunyan Liu
2014-02-13 0:24 ` Eric Blake
2014-02-12 6:33 ` [Qemu-devel] [PATCH v20 11/26] qcow2.c: replace QEMUOptionParameter with QemuOpts in create Chunyan Liu
2014-02-13 0:30 ` Eric Blake
2014-02-12 6:33 ` [Qemu-devel] [PATCH v20 12/26] qcow2.c: replace QEMUOptionParameter with QemuOpts in amend options Chunyan Liu
2014-02-17 17:57 ` Eric Blake
2014-02-12 6:33 ` [Qemu-devel] [PATCH v20 13/26] qed.c: replace QEMUOptionParameter with QemuOpts Chunyan Liu
2014-02-17 18:01 ` Eric Blake
2014-02-18 7:42 ` Chunyan Liu
2014-02-12 6:33 ` [Qemu-devel] [PATCH v20 14/26] raw-posix.c: " Chunyan Liu
2014-02-17 18:18 ` Eric Blake
2014-02-12 6:33 ` [Qemu-devel] [PATCH v20 15/26] raw-win32.c: " Chunyan Liu
2014-02-17 18:42 ` Eric Blake
2014-02-12 6:33 ` [Qemu-devel] [PATCH v20 16/26] raw_bsd.c: " Chunyan Liu
2014-02-17 18:49 ` Eric Blake
2014-02-12 6:33 ` [Qemu-devel] [PATCH v20 17/26] rbd.c: " Chunyan Liu
2014-02-17 18:57 ` Eric Blake
2014-02-18 5:56 ` Chunyan Liu
2014-02-12 6:33 ` [Qemu-devel] [PATCH v20 18/26] sheepdog.c: " Chunyan Liu
2014-02-17 19:01 ` Eric Blake
2014-02-18 8:18 ` Chunyan Liu
2014-02-12 6:33 ` [Qemu-devel] [PATCH v20 19/26] ssh.c: " Chunyan Liu
2014-02-17 23:26 ` Eric Blake
2014-02-12 6:33 ` [Qemu-devel] [PATCH v20 20/26] vdi.c: " Chunyan Liu
2014-02-18 0:00 ` Eric Blake
2014-02-12 6:33 ` [Qemu-devel] [PATCH v20 21/26] vmdk.c: " Chunyan Liu
2014-02-12 6:33 ` [Qemu-devel] [PATCH v20 22/26] vpc.c: " Chunyan Liu
2014-02-12 6:33 ` [Qemu-devel] [PATCH v20 23/26] vhdx.c: " Chunyan Liu
2014-02-19 18:38 ` Eric Blake
2014-02-12 6:33 ` [Qemu-devel] [PATCH v20 24/26] vvfat.c: " Chunyan Liu
2014-02-12 6:33 ` [Qemu-devel] [PATCH v20 25/26] cleanup QEMUOptionParameter Chunyan Liu
2014-02-13 0:35 ` Eric Blake
2014-02-12 6:33 ` [Qemu-devel] [PATCH v20 26/26] change back to original name from bdrv_create2 to bdrv_create Chunyan Liu
2014-02-13 0:32 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FBFE38.4070900@redhat.com \
--to=eblake@redhat.com \
--cc=cyliu@suse.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=wdongxu@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).