From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53299) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WDkEB-00033p-U4 for qemu-devel@nongnu.org; Wed, 12 Feb 2014 19:32:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WDkE7-00058x-Ds for qemu-devel@nongnu.org; Wed, 12 Feb 2014 19:32:31 -0500 Received: from mx1.redhat.com ([209.132.183.28]:15859) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WDkE7-00058t-5R for qemu-devel@nongnu.org; Wed, 12 Feb 2014 19:32:27 -0500 Message-ID: <52FC1297.5060407@redhat.com> Date: Wed, 12 Feb 2014 17:32:23 -0700 From: Eric Blake MIME-Version: 1.0 References: <1392186806-10418-1-git-send-email-cyliu@suse.com> <1392186806-10418-27-git-send-email-cyliu@suse.com> In-Reply-To: <1392186806-10418-27-git-send-email-cyliu@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="WpgqMV7s601qbqT5iaBLAnvW8DdNMKcul" Subject: Re: [Qemu-devel] [PATCH v20 26/26] change back to original name from bdrv_create2 to bdrv_create List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chunyan Liu , qemu-devel@nongnu.org Cc: kwolf@redhat.com, Dong Xu Wang , stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --WpgqMV7s601qbqT5iaBLAnvW8DdNMKcul Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02/11/2014 11:33 PM, Chunyan Liu wrote: > Rename the new driver callback bdrv_create2 to the old name bdrv_create= =2E >=20 > Signed-off-by: Dong Xu Wang > Signed-off-by: Chunyan Liu > --- > block.c | 4 ++-- > block/cow.c | 2 +- > block/gluster.c | 8 ++++---- > block/iscsi.c | 2 +- > block/qcow.c | 2 +- > block/qcow2.c | 2 +- > block/qed.c | 2 +- > block/raw-posix.c | 10 +++++----- > block/raw-win32.c | 2 +- > block/raw_bsd.c | 2 +- > block/rbd.c | 2 +- > block/sheepdog.c | 6 +++--- > block/ssh.c | 2 +- > block/vdi.c | 2 +- > block/vhdx.c | 2 +- > block/vmdk.c | 2 +- > block/vpc.c | 2 +- > include/block/block_int.h | 2 +- > 18 files changed, 28 insertions(+), 28 deletions(-) I would squash this in to the previous patch. > +++ b/block/gluster.c > @@ -620,7 +620,7 @@ static BlockDriver bdrv_gluster =3D { > .bdrv_needs_filename =3D true, > .bdrv_file_open =3D qemu_gluster_open, > .bdrv_close =3D qemu_gluster_close, > - .bdrv_create2 =3D qemu_gluster_create, > + .bdrv_create =3D qemu_gluster_create, Don't mess up indentation. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --WpgqMV7s601qbqT5iaBLAnvW8DdNMKcul Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJS/BKXAAoJEKeha0olJ0NqXQEIAJTUlU93c9KtxLzCXf/8vQwi Wn1yDJnj36GIG3/kgck/K0NVVv+qKh91Ie6bBU7RvQB17CVjFc97B1IZfF+XN398 OXVVBLLOOAs/yLj9wyeYr/i+4nj8opufmXpXZhGitv3QJRY/JXPvMjIZ+B+oSZOu k3q5yLoxW4TysGFeVbnf3JkMLETrABPWRkhGmB8OkVqXOAYZueg63w+7oY8pK2Cj My73u2CHWQZjKn+aQx+5aQgZqc88dUkB/Q6b0913xEVZKBJMyba0UOUOUITnkBEp 8kPwX+gGxxlYs/yXyJz9gmoiAEeoIw/T2xPTE0KGItUL0LNl7s51j+L1utMfWDM= =rxqK -----END PGP SIGNATURE----- --WpgqMV7s601qbqT5iaBLAnvW8DdNMKcul--