From: Paolo Bonzini <pbonzini@redhat.com>
To: Eric Blake <eblake@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
qemu-devel@nongnu.org
Cc: kwolf@redhat.com, peter.maydell@linaro.org,
mdroth@linux.vnet.ibm.com, aliguori@amazon.com
Subject: Re: [Qemu-devel] [PATCH 13/13] qapi: Add missing null check to opts_start_struct()
Date: Thu, 13 Feb 2014 10:30:41 +0100 [thread overview]
Message-ID: <52FC90C1.5080807@redhat.com> (raw)
In-Reply-To: <52F8F01D.5000707@redhat.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Il 10/02/2014 16:28, Eric Blake ha scritto:
| On 02/10/2014 07:20 AM, Markus Armbruster wrote:
|> Argument is null when visiting an unboxed struct. I can't see
|> such a visit in the current code. Fix it anyway.
|
| Is this a sign of missing testsuite coverage?
Yes, likely.
Paolo
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQIcBAEBAgAGBQJS/JDBAAoJEBvWZb6bTYbyAq4QAIH0kuK64lI9F0QeSYdC7vXZ
UFbccRz3sZXl7VBZXPpJNUOtEYsw/UXYYxEKXWedVUTWF7YWORe6fzd377Eti2w1
O8roausYt6J1czWnoufp8hsjBQJz72ydxEIDRWK1ip+8V0ZEqlbO4TSRRkZXNz1b
dFn5A3TsW0nKGLyZiD8LxA5mdI3WLAuUDV3zWXQstovLFrG4/cqQv4zyyIRh7zG6
bDzPx4zmswRynedwcet2i8atZFhgdWvjx1OouuKLqMK/9aRVuThwiKPwWjyrwhkr
o4QKEdHlNZZbCvbrqB+4XizRyqhW61uf3JylPcH/SGgLGXHxLyutciC4FosJE5js
CPpsq5edPWJM07eKYiisBwt4CU6P+8hrhMtJ+Yo1P3WyMgdwGTQHyqDk/ZDUq+pM
3Hmwi36DALBSnIfmeTndgzVXbPtJe4W87ndBmx9UpXNnUDzgkVd0Kfje+NU7lsLv
tgROyQmhhoc/e5VuClV6C/2tILsx8gEGEacbSS/FTnZGUlnoTSlpenGrSLLcCHpy
alkmNDP/D+reYE7BV9zvSojBJOPNNKS0qQ1Y5528+sr8XsbuaaL3UQCE0oQHjCAK
iPYyfkzCyTgB3iFHVxunEQ+j6oaMkbY28YJTnIUsr6jOWpWlT3pW3VMEekmjcZi2
CF0f7RztKQtHglYyuFgW
=IAMx
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2014-02-13 9:31 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-10 14:20 [Qemu-devel] [PATCH v2 00/13] qapi: Test coverage & clean up generated code Markus Armbruster
2014-02-10 14:20 ` [Qemu-devel] [PATCH v2 01/13] tests/qapi-schema: Actually check successful QMP command response Markus Armbruster
2014-02-10 14:20 ` [Qemu-devel] [PATCH v2 02/13] tests/qapi-schema: Cover optional command arguments Markus Armbruster
2014-02-10 14:20 ` [Qemu-devel] [PATCH v2 03/13] tests/qapi-schema: Cover simple argument types Markus Armbruster
2014-02-10 14:20 ` [Qemu-devel] [PATCH v2 04/13] tests/qapi-schema: Cover anonymous union types Markus Armbruster
2014-02-10 14:20 ` [Qemu-devel] [PATCH v2 05/13] tests/qapi-schema: Cover complex types with base Markus Armbruster
2014-02-10 14:20 ` [Qemu-devel] [PATCH v2 06/13] tests/qapi-schema: Cover union " Markus Armbruster
2014-02-10 14:20 ` [Qemu-devel] [PATCH v2 07/13] tests/qapi-schema: Cover flat union types Markus Armbruster
2014-02-10 14:20 ` [Qemu-devel] [PATCH v2 08/13] qapi: Fix licensing of scripts Markus Armbruster
2014-02-10 15:26 ` Eric Blake
2014-02-10 14:20 ` [Qemu-devel] [PATCH v2 09/13] qapi: Drop nonsensical header guard in generated qapi-visit.c Markus Armbruster
2014-02-10 14:20 ` [Qemu-devel] [PATCH v2 10/13] qapi: Drop unused code in qapi-commands.py Markus Armbruster
2014-02-10 14:20 ` [Qemu-devel] [PATCH v2 11/13] qapi: Clean up null checking in generated visitors Markus Armbruster
2014-02-10 14:20 ` [Qemu-devel] [PATCH 12/13] qapi: Clean up superfluous null check in qapi_dealloc_type_str() Markus Armbruster
2014-02-10 15:27 ` Eric Blake
2014-02-10 14:20 ` [Qemu-devel] [PATCH 13/13] qapi: Add missing null check to opts_start_struct() Markus Armbruster
2014-02-10 15:28 ` Eric Blake
2014-02-13 9:30 ` Paolo Bonzini [this message]
2014-02-13 9:31 ` [Qemu-devel] [PATCH v2 00/13] qapi: Test coverage & clean up generated code Paolo Bonzini
2014-02-13 13:41 ` Luiz Capitulino
2014-02-13 13:57 ` Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FC90C1.5080807@redhat.com \
--to=pbonzini@redhat.com \
--cc=aliguori@amazon.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).