From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39121) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WDsdE-00064U-0p for qemu-devel@nongnu.org; Thu, 13 Feb 2014 04:31:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WDsd9-0001WF-2t for qemu-devel@nongnu.org; Thu, 13 Feb 2014 04:30:55 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56417) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WDsd8-0001W2-Qt for qemu-devel@nongnu.org; Thu, 13 Feb 2014 04:30:51 -0500 Message-ID: <52FC90C1.5080807@redhat.com> Date: Thu, 13 Feb 2014 10:30:41 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1392042045-31525-1-git-send-email-armbru@redhat.com> <1392042045-31525-14-git-send-email-armbru@redhat.com> <52F8F01D.5000707@redhat.com> In-Reply-To: <52F8F01D.5000707@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 13/13] qapi: Add missing null check to opts_start_struct() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , Markus Armbruster , qemu-devel@nongnu.org Cc: kwolf@redhat.com, peter.maydell@linaro.org, mdroth@linux.vnet.ibm.com, aliguori@amazon.com -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Il 10/02/2014 16:28, Eric Blake ha scritto: | On 02/10/2014 07:20 AM, Markus Armbruster wrote: |> Argument is null when visiting an unboxed struct. I can't see |> such a visit in the current code. Fix it anyway. | | Is this a sign of missing testsuite coverage? Yes, likely. Paolo -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJS/JDBAAoJEBvWZb6bTYbyAq4QAIH0kuK64lI9F0QeSYdC7vXZ UFbccRz3sZXl7VBZXPpJNUOtEYsw/UXYYxEKXWedVUTWF7YWORe6fzd377Eti2w1 O8roausYt6J1czWnoufp8hsjBQJz72ydxEIDRWK1ip+8V0ZEqlbO4TSRRkZXNz1b dFn5A3TsW0nKGLyZiD8LxA5mdI3WLAuUDV3zWXQstovLFrG4/cqQv4zyyIRh7zG6 bDzPx4zmswRynedwcet2i8atZFhgdWvjx1OouuKLqMK/9aRVuThwiKPwWjyrwhkr o4QKEdHlNZZbCvbrqB+4XizRyqhW61uf3JylPcH/SGgLGXHxLyutciC4FosJE5js CPpsq5edPWJM07eKYiisBwt4CU6P+8hrhMtJ+Yo1P3WyMgdwGTQHyqDk/ZDUq+pM 3Hmwi36DALBSnIfmeTndgzVXbPtJe4W87ndBmx9UpXNnUDzgkVd0Kfje+NU7lsLv tgROyQmhhoc/e5VuClV6C/2tILsx8gEGEacbSS/FTnZGUlnoTSlpenGrSLLcCHpy alkmNDP/D+reYE7BV9zvSojBJOPNNKS0qQ1Y5528+sr8XsbuaaL3UQCE0oQHjCAK iPYyfkzCyTgB3iFHVxunEQ+j6oaMkbY28YJTnIUsr6jOWpWlT3pW3VMEekmjcZi2 CF0f7RztKQtHglYyuFgW =IAMx -----END PGP SIGNATURE-----