From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel <qemu-devel@nongnu.org>,
"Alexander Graf" <agraf@suse.de>,
"Jens Freimann" <jfrei@linux.vnet.ibm.com>,
"Anthony Liguori" <anthony@codemonkey.ws>,
"Cornelia Huck" <cornelia.huck@de.ibm.com>,
"Andreas Färber" <afaerber@suse.de>,
"Richard Henderson" <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PULL 2/3] s390-ccw.img: Fix sporadic errors with ccw boot image - initialize css
Date: Thu, 13 Feb 2014 11:05:54 +0100 [thread overview]
Message-ID: <52FC9902.5030406@de.ibm.com> (raw)
In-Reply-To: <CAFEAcA_UKU6SfVGpwoOUNHxKbeC7DG4FeqOZ873+=Dq7=1vHMA@mail.gmail.com>
On 13/02/14 10:55, Peter Maydell wrote:
> On 13 February 2014 09:17, Christian Borntraeger <borntraeger@de.ibm.com> wrote:
>> static void virtio_setup(uint64_t dev_info)
>> {
>> + struct subchannel_id blk_schid = { .one = 1};
>
> Missing space before the "}" I think.
checkpatch accepts both ways:
a) struct subchannel_id blk_schid = { .one = 1};
b) struct subchannel_id blk_schid = { .one = 1 };
so, change it or keep it?
Christian
next prev parent reply other threads:[~2014-02-13 10:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-13 9:17 [Qemu-devel] [PULL 0/3] s390-ccw.img: fix sporadic boot errors Christian Borntraeger
2014-02-13 9:17 ` [Qemu-devel] [PULL 1/3] s390-ccw.img: Fix sporadic reboot hangs: Initialize next_idx Christian Borntraeger
2014-02-13 9:38 ` Cornelia Huck
2014-02-13 15:15 ` Richard Henderson
2014-02-13 19:39 ` Christian Borntraeger
2014-02-13 21:41 ` [Qemu-devel] [PATCH/RFC] clear bss memory of ROMS Christian Borntraeger
2014-02-13 9:17 ` [Qemu-devel] [PULL 2/3] s390-ccw.img: Fix sporadic errors with ccw boot image - initialize css Christian Borntraeger
2014-02-13 9:39 ` Cornelia Huck
2014-02-13 9:55 ` Peter Maydell
2014-02-13 10:05 ` Christian Borntraeger [this message]
2014-02-13 11:04 ` Peter Maydell
2014-02-13 12:59 ` Christian Borntraeger
2014-02-13 9:17 ` [Qemu-devel] [PULL 3/3] s390-ccw.img: new binary rom to match latest fixes Christian Borntraeger
2014-02-13 9:21 ` [Qemu-devel] [PULL 0/3] s390-ccw.img: fix sporadic boot errors Peter Maydell
2014-02-13 9:26 ` Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FC9902.5030406@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=anthony@codemonkey.ws \
--cc=cornelia.huck@de.ibm.com \
--cc=jfrei@linux.vnet.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).