From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49353)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1WDvsv-0005Xx-7o
	for qemu-devel@nongnu.org; Thu, 13 Feb 2014 07:59:30 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1WDvsm-0001LD-AX
	for qemu-devel@nongnu.org; Thu, 13 Feb 2014 07:59:21 -0500
Received: from e06smtp16.uk.ibm.com ([195.75.94.112]:47237)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1WDvsm-0001L3-0r
	for qemu-devel@nongnu.org; Thu, 13 Feb 2014 07:59:12 -0500
Received: from /spool/local
	by e06smtp16.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <borntraeger@de.ibm.com>;
	Thu, 13 Feb 2014 12:59:10 -0000
Received: from b06cxnps3074.portsmouth.uk.ibm.com
	(d06relay09.portsmouth.uk.ibm.com [9.149.109.194])
	by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id B6C35219005C
	for <qemu-devel@nongnu.org>; Thu, 13 Feb 2014 12:59:05 +0000 (GMT)
Received: from d06av08.portsmouth.uk.ibm.com (d06av08.portsmouth.uk.ibm.com
	[9.149.37.249])
	by b06cxnps3074.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with
	ESMTP id s1DCwuIc59244680
	for <qemu-devel@nongnu.org>; Thu, 13 Feb 2014 12:58:56 GMT
Received: from d06av08.portsmouth.uk.ibm.com (localhost [127.0.0.1])
	by d06av08.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with
	ESMTP id s1DCx7T0028893
	for <qemu-devel@nongnu.org>; Thu, 13 Feb 2014 05:59:07 -0700
Message-ID: <52FCC19A.80609@de.ibm.com>
Date: Thu, 13 Feb 2014 13:59:06 +0100
From: Christian Borntraeger <borntraeger@de.ibm.com>
MIME-Version: 1.0
References: <1392283031-40129-1-git-send-email-borntraeger@de.ibm.com>
	<1392283031-40129-3-git-send-email-borntraeger@de.ibm.com>
	<CAFEAcA_UKU6SfVGpwoOUNHxKbeC7DG4FeqOZ873+=Dq7=1vHMA@mail.gmail.com>
	<52FC9902.5030406@de.ibm.com>
	<CAFEAcA_7csNxLUbOnOgr_L2yri+vg9fnjO=-WjaAj_xnVCctvg@mail.gmail.com>
In-Reply-To: <CAFEAcA_7csNxLUbOnOgr_L2yri+vg9fnjO=-WjaAj_xnVCctvg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL 2/3] s390-ccw.img: Fix sporadic errors with
 ccw boot image - initialize css
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel <qemu-devel@nongnu.org>, Alexander Graf <agraf@suse.de>, Jens Freimann <jfrei@linux.vnet.ibm.com>, Anthony Liguori <anthony@codemonkey.ws>, Cornelia Huck <cornelia.huck@de.ibm.com>, =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>, Richard Henderson <rth@twiddle.net>

On 13/02/14 12:04, Peter Maydell wrote:
> On 13 February 2014 10:05, Christian Borntraeger <borntraeger@de.ibm.com> wrote:
>> On 13/02/14 10:55, Peter Maydell wrote:
>>> On 13 February 2014 09:17, Christian Borntraeger <borntraeger@de.ibm.com> wrote:
>>>>  static void virtio_setup(uint64_t dev_info)
>>>>  {
>>>> +    struct subchannel_id blk_schid = { .one = 1};
>>>
>>> Missing space before the "}" I think.
>>
>> checkpatch accepts both ways:
>> a)    struct subchannel_id blk_schid = { .one = 1};
>> b)    struct subchannel_id blk_schid = { .one = 1 };
>>
>> so, change it or keep it?
> 
> checkpatch isn't infallible. I think having the space
> looks better. In any case you should be consistent
> about whether you use a space with both the opening
> and the closing brace -- at the moment you've got a
> space at one end and not the other.
> 
> thanks

Ok changed. Will wait for some more feedback and send
an updated pull requests.

Christian