From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48178) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WDxlq-000287-HF for qemu-devel@nongnu.org; Thu, 13 Feb 2014 10:00:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WDxll-00076b-NG for qemu-devel@nongnu.org; Thu, 13 Feb 2014 10:00:10 -0500 Received: from mail-qc0-x234.google.com ([2607:f8b0:400d:c01::234]:40443) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WDxll-00073T-Jd for qemu-devel@nongnu.org; Thu, 13 Feb 2014 10:00:05 -0500 Received: by mail-qc0-f180.google.com with SMTP id i17so17928604qcy.39 for ; Thu, 13 Feb 2014 07:00:04 -0800 (PST) Sender: Richard Henderson Message-ID: <52FCDDEF.2090307@twiddle.net> Date: Thu, 13 Feb 2014 06:59:59 -0800 From: Richard Henderson MIME-Version: 1.0 References: <1392287206-30889-1-git-send-email-huw@codeweavers.com> In-Reply-To: <1392287206-30889-1-git-send-email-huw@codeweavers.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] tcg-arm: The shift count of op_rotl_i32 is in args[2] not args[1]. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Huw Davies , qemu devel On 02/13/2014 02:26 AM, Huw Davies wrote: > It's this that should be subtracted from 0x20 when converting to a right rotate. > > Signed-off-by: Huw Davies > --- > tcg/arm/tcg-target.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson r~