From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55428) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WE0Ao-0008QV-Tv for qemu-devel@nongnu.org; Thu, 13 Feb 2014 12:34:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WE0Ak-0000ix-1n for qemu-devel@nongnu.org; Thu, 13 Feb 2014 12:34:06 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34257) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WE0Aj-0000ij-Q1 for qemu-devel@nongnu.org; Thu, 13 Feb 2014 12:34:01 -0500 Message-ID: <52FD0203.3010500@redhat.com> Date: Thu, 13 Feb 2014 18:33:55 +0100 From: Michal Privoznik MIME-Version: 1.0 References: <52EBE77E.2080507@redhat.com> In-Reply-To: <52EBE77E.2080507@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] qga: Don't require 'time' argument in guest-set-time command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org Cc: Marcelo Tosatti , Laszlo Ersek , mdroth@linux.vnet.ibm.com On 31.01.2014 19:12, Eric Blake wrote: > On 01/31/2014 03:29 AM, Michal Privoznik wrote: >> As the description to the guest-set-time states, the command is >> there to ease time synchronization after resume. If guest was >> suspended for longer period of time, its system time can go off >> so badly, that even NTP refuses to set it. That's why the command >> was invented: to give users chance to set the time (not >> necessarily 100% correct). However, there's is no real need for >> us to require users to pass an arbitrary time. Especially if we >> can read the correct value from RTC (boiling down to reading >> host's time). Hence this commit enables logic: >> >> guest-set-time() == guest-set-time($now_from_rtc) >> >> Signed-off-by: Michal Privoznik >> --- >> diff to v1: >> -Fix checkpatch.pl warnings >> >> qga/commands-posix.c | 41 +++++++++++++++++++++++++---------------- >> qga/commands-win32.c | 34 +++++++++++++++++++++++----------- >> qga/qapi-schema.json | 9 +++++---- >> 3 files changed, 53 insertions(+), 31 deletions(-) > > Reviewed-by: Eric Blake > May I kindly ask somebody to merge this? Or is 3ACKs required for the guest agent too? Thanks in advance! Michal