From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58475) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WE0ME-0004mp-S5 for qemu-devel@nongnu.org; Thu, 13 Feb 2014 12:46:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WE0MA-00053g-0W for qemu-devel@nongnu.org; Thu, 13 Feb 2014 12:45:54 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50458) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WE0M9-00053Y-PC for qemu-devel@nongnu.org; Thu, 13 Feb 2014 12:45:49 -0500 Message-ID: <52FD04C7.5030701@redhat.com> Date: Thu, 13 Feb 2014 10:45:43 -0700 From: Eric Blake MIME-Version: 1.0 References: <1392299426-13160-3-git-send-email-imammedo@redhat.com> <1392307986-27730-1-git-send-email-imammedo@redhat.com> In-Reply-To: <1392307986-27730-1-git-send-email-imammedo@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="x7A0jN2BdeP9pUBtnEJdeUI8Lr0WfXfp2" Subject: Re: [Qemu-devel] [PATCH v3] vl: convert -m to QemuOpts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , qemu-devel@nongnu.org Cc: kwolf@redhat.com, peter.crosthwaite@xilinx.com, akong@redhat.com, stefanha@redhat.com, mjt@tls.msk.ru, armbru@redhat.com, mreitz@redhat.com, aliguori@amazon.com, pbonzini@redhat.com, lcapitulino@redhat.com, lersek@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --x7A0jN2BdeP9pUBtnEJdeUI8Lr0WfXfp2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02/13/2014 09:13 AM, Igor Mammedov wrote: > Adds option to -m > "mem" - startup memory amount >=20 > For compatibility with legacy CLI if suffix-less number is passed, > it assumes amount in MiB. >=20 > Otherwise user is free to use suffixed number using suffixes b,k/K,M,G >=20 > Signed-off-by: Igor Mammedov > Signed-off-by: Paolo Bonzini > --- > v3: > - fixes suggested by Eric Blake > - check for empty string in more efficient way > - fix MB/MiB inconsistency > - use EXIT_FAILURE instead of 1 > - add missing exit() if overflow occurres Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --x7A0jN2BdeP9pUBtnEJdeUI8Lr0WfXfp2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJS/QTHAAoJEKeha0olJ0Nq1YsIAKY/pCvTOxMcCSxLDQ+OfBqG YF+YeRBklnHy9l2qWAah7FrL+D9yq0B81RtibosQfd1pM9hR46HATa7b/EWsJi9y ePVslgkZlPRFYxCb3931gbuV9odAFA1RoiXMWmjl4mLCPIu5/zMerEzascgC/FLD K7ioXdwH7JOj/irUpAfo8gc2sv8o2qnWYOlGyYd+5ss8eowS7rUex/wgjOQacxih rxe5m30oCc+BA6l2ZI4XzOKDqZRurIeragmqeb4N7wn9plh/eEMtHEhpSQKLTEhr J6/C98xZ5JQ4LTFzjYDByN72W2KeLkW/EUAySS8MDC2wNllSUqJ+zgTJQYYz93M= =t/h0 -----END PGP SIGNATURE----- --x7A0jN2BdeP9pUBtnEJdeUI8Lr0WfXfp2--