From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58133) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WE2YN-0000yS-17 for qemu-devel@nongnu.org; Thu, 13 Feb 2014 15:06:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WE2YH-0001T9-2d for qemu-devel@nongnu.org; Thu, 13 Feb 2014 15:06:34 -0500 Received: from mx1.redhat.com ([209.132.183.28]:30110) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WE2YG-0001Ss-Q3 for qemu-devel@nongnu.org; Thu, 13 Feb 2014 15:06:28 -0500 Message-ID: <52FD25BA.2010309@redhat.com> Date: Thu, 13 Feb 2014 21:06:18 +0100 From: Laszlo Ersek MIME-Version: 1.0 References: <1392299426-13160-3-git-send-email-imammedo@redhat.com> <1392307986-27730-1-git-send-email-imammedo@redhat.com> <52FD04C7.5030701@redhat.com> In-Reply-To: <52FD04C7.5030701@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3] vl: convert -m to QemuOpts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: kwolf@redhat.com, peter.crosthwaite@xilinx.com, akong@redhat.com, stefanha@redhat.com, mjt@tls.msk.ru, qemu-devel@nongnu.org, armbru@redhat.com, aliguori@amazon.com, lcapitulino@redhat.com, pbonzini@redhat.com, mreitz@redhat.com On 02/13/14 18:45, Eric Blake wrote: > On 02/13/2014 09:13 AM, Igor Mammedov wrote: >> Adds option to -m >> "mem" - startup memory amount >> >> For compatibility with legacy CLI if suffix-less number is passed, >> it assumes amount in MiB. >> >> Otherwise user is free to use suffixed number using suffixes b,k/K,M,G >> >> Signed-off-by: Igor Mammedov >> Signed-off-by: Paolo Bonzini >> --- >> v3: >> - fixes suggested by Eric Blake >> - check for empty string in more efficient way >> - fix MB/MiB inconsistency >> - use EXIT_FAILURE instead of 1 >> - add missing exit() if overflow occurres > > Reviewed-by: Eric Blake Me too: Reviewed-by: Laszlo Ersek