From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58506) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WEJye-0006iN-FH for qemu-devel@nongnu.org; Fri, 14 Feb 2014 09:42:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WEJyW-0008ET-Mu for qemu-devel@nongnu.org; Fri, 14 Feb 2014 09:42:52 -0500 Received: from cantor2.suse.de ([195.135.220.15]:47496 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WEJyW-0008EG-CZ for qemu-devel@nongnu.org; Fri, 14 Feb 2014 09:42:44 -0500 Message-ID: <52FE2B61.8020902@suse.de> Date: Fri, 14 Feb 2014 15:42:41 +0100 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1391856067-16860-1-git-send-email-stefanha@redhat.com> <20140214143249.GG17391@stefanha-thinkpad.redhat.com> In-Reply-To: <20140214143249.GG17391@stefanha-thinkpad.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] qtest: include system headers before user headers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , Stefan Hajnoczi Cc: Peter Maydell , qemu-devel@nongnu.org, Anthony Liguori Am 14.02.2014 15:32, schrieb Stefan Hajnoczi: > On Sat, Feb 08, 2014 at 11:41:07AM +0100, Stefan Hajnoczi wrote: >> It is dangerous to include user headers before system headers since us= er >> macros can affect system headers. >> >> Signed-off-by: Stefan Hajnoczi >> --- >> tests/endianness-test.c | 2 +- >> tests/fw_cfg-test.c | 7 +++---- >> tests/i440fx-test.c | 11 +++++------ >> tests/m48t59-test.c | 3 ++- >> tests/qom-test.c | 3 ++- >> tests/rtc-test.c | 5 +++-- >> tests/tmp105-test.c | 5 +++-- >> 7 files changed, 19 insertions(+), 17 deletions(-) >=20 > Ping? I felt it wasn't long enough on the list before my v1 PULL. I can pick it up for v2, now that no one has objected. > Is anyone willing to be qtest maintainer, i.e. you understand qtest, ca= n > review patches, and will send pull requests? I don't feel like the official qtest maintainer, but I care and am actively working on it. I would consider it best to have individual tests maintained by subsystem maintainers and only define a maintainer for the core libqtest.c/qtest.c code. Cheers, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg