Re: [Qemu-devel] [PULL 25/48] tests: Add ne2000 qtest

["Andreas Färber" <afaerber@suse.de>]

Am 10.02.2014 19:36, schrieb Andreas Färber:
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
>  tests/Makefile      |  1 +
>  tests/ne2000-test.c | 33 +++++++++++++++++++++++++++++++++
>  2 files changed, 34 insertions(+)
>  create mode 100644 tests/ne2000-test.c
> 
> diff --git a/tests/Makefile b/tests/Makefile
> index 4f9dd6d..62ae7f8 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -218,6 +218,7 @@ tests/rtl8139-test$(EXESUF): tests/rtl8139-test.o
>  tests/pcnet-test$(EXESUF): tests/pcnet-test.o
>  tests/eepro100-test$(EXESUF): tests/eepro100-test.o
>  tests/vmxnet3-test$(EXESUF): tests/vmxnet3-test.o
> +tests/ne2000-test$(EXESUF): tests/ne2000-test.o
>  tests/qom-test$(EXESUF): tests/qom-test.o
>  tests/blockdev-test$(EXESUF): tests/blockdev-test.o $(libqos-pc-obj-y)
>  tests/qdev-monitor-test$(EXESUF): tests/qdev-monitor-test.o $(libqos-pc-obj-y)

This is lacking:

diff --git a/tests/Makefile b/tests/Makefile
index 59097df..8ece028 100644
--- a/tests/Makefile
+++ b/tests/Makefile
@@ -74,6 +74,8 @@ gcov-files-pci-y += hw/net/pcnet.c
 gcov-files-pci-y += hw/net/pcnet-pci.c
 check-qtest-pci-y += tests/eepro100-test$(EXESUF)
 gcov-files-pci-y += hw/net/eepro100.c
+check-qtest-pci-y += tests/ne2000-test$(EXESUF)
+gcov-files-pci-y += hw/net/ne2000.c

 check-qtest-i386-y = tests/endianness-test$(EXESUF)
 check-qtest-i386-y += tests/fdc-test$(EXESUF)

Fixing in v2.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg