From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37510)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WEOn1-00011r-PR
	for qemu-devel@nongnu.org; Fri, 14 Feb 2014 14:51:17 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WEOmv-0004Ul-Qs
	for qemu-devel@nongnu.org; Fri, 14 Feb 2014 14:51:11 -0500
Received: from cantor2.suse.de ([195.135.220.15]:51743 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WEOmv-0004UZ-KZ
	for qemu-devel@nongnu.org; Fri, 14 Feb 2014 14:51:05 -0500
Message-ID: <52FE73A4.5090608@suse.de>
Date: Fri, 14 Feb 2014 20:51:00 +0100
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1392057426-31990-1-git-send-email-afaerber@suse.de>
	<1392057426-31990-26-git-send-email-afaerber@suse.de>
In-Reply-To: <1392057426-31990-26-git-send-email-afaerber@suse.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PULL 25/48] tests: Add ne2000 qtest
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Stefan Hajnoczi <stefanha@redhat.com>

Am 10.02.2014 19:36, schrieb Andreas F=C3=A4rber:
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> Signed-off-by: Andreas F=C3=A4rber <afaerber@suse.de>
> ---
>  tests/Makefile      |  1 +
>  tests/ne2000-test.c | 33 +++++++++++++++++++++++++++++++++
>  2 files changed, 34 insertions(+)
>  create mode 100644 tests/ne2000-test.c
>=20
> diff --git a/tests/Makefile b/tests/Makefile
> index 4f9dd6d..62ae7f8 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -218,6 +218,7 @@ tests/rtl8139-test$(EXESUF): tests/rtl8139-test.o
>  tests/pcnet-test$(EXESUF): tests/pcnet-test.o
>  tests/eepro100-test$(EXESUF): tests/eepro100-test.o
>  tests/vmxnet3-test$(EXESUF): tests/vmxnet3-test.o
> +tests/ne2000-test$(EXESUF): tests/ne2000-test.o
>  tests/qom-test$(EXESUF): tests/qom-test.o
>  tests/blockdev-test$(EXESUF): tests/blockdev-test.o $(libqos-pc-obj-y)
>  tests/qdev-monitor-test$(EXESUF): tests/qdev-monitor-test.o $(libqos-p=
c-obj-y)

This is lacking:

diff --git a/tests/Makefile b/tests/Makefile
index 59097df..8ece028 100644
--- a/tests/Makefile
+++ b/tests/Makefile
@@ -74,6 +74,8 @@ gcov-files-pci-y +=3D hw/net/pcnet.c
 gcov-files-pci-y +=3D hw/net/pcnet-pci.c
 check-qtest-pci-y +=3D tests/eepro100-test$(EXESUF)
 gcov-files-pci-y +=3D hw/net/eepro100.c
+check-qtest-pci-y +=3D tests/ne2000-test$(EXESUF)
+gcov-files-pci-y +=3D hw/net/ne2000.c

 check-qtest-i386-y =3D tests/endianness-test$(EXESUF)
 check-qtest-i386-y +=3D tests/fdc-test$(EXESUF)

Fixing in v2.

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg