From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42494) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WEPHi-0000bt-Rl for qemu-devel@nongnu.org; Fri, 14 Feb 2014 15:23:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WEPHa-0005MF-Em for qemu-devel@nongnu.org; Fri, 14 Feb 2014 15:22:54 -0500 Received: from mail-qc0-x232.google.com ([2607:f8b0:400d:c01::232]:61353) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WEPHa-0005MB-AJ for qemu-devel@nongnu.org; Fri, 14 Feb 2014 15:22:46 -0500 Received: by mail-qc0-f178.google.com with SMTP id m20so20585337qcx.23 for ; Fri, 14 Feb 2014 12:22:46 -0800 (PST) Sender: Paolo Bonzini Message-ID: <52FE7B12.8000303@redhat.com> Date: Fri, 14 Feb 2014 21:22:42 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1392138233-26407-1-git-send-email-pbonzini@redhat.com> <1392138233-26407-10-git-send-email-pbonzini@redhat.com> <20140214164540.GK32343@dhcp-200-207.str.redhat.com> <52FE4C12.8050607@redhat.com> <20140214181926.GM32343@dhcp-200-207.str.redhat.com> In-Reply-To: <20140214181926.GM32343@dhcp-200-207.str.redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 09/20] cow: correctly propagate errors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: famz@redhat.com, qemu-devel@nongnu.org Il 14/02/2014 19:19, Kevin Wolf ha scritto: > Eventually this function will return void; having both a -errno return > and the errp argument is just an intermediate step (as probably in all > other cases). So I still think this is going in the wrong direction and > will make the conversion harder than necessary. Now that this patch > series is already here, I won't insist on respinning it, but please > be aware that you're just creating additional work for other people and > keep existing local_errs in any future patches. Ok, this makes sense, but it is an exception to the general policy. :) I'll respin v3 and test NBD too. Paolo