From: Max Reitz <mreitz@redhat.com>
To: "Benoît Canet" <benoit.canet@irqsave.net>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, famz@redhat.com, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH V17 00/12] quorum block filter
Date: Sat, 15 Feb 2014 02:15:06 +0100 [thread overview]
Message-ID: <52FEBF9A.3080500@redhat.com> (raw)
In-Reply-To: <1392242799-16364-1-git-send-email-benoit.canet@irqsave.net>
On 12.02.2014 23:06, Benoît Canet wrote:
> I post this for review in prevision of 2.0 feature freeze.
> Even if the series look correct please wait before merging because:
>
> The QMP events in the "Add quorum mechanism" definitively needs to be reviewed
> by Eric as they where changed.
>
> I did not found any bugs while testing this version but I am willing to test the
> code further before it's applied even it's reviewed by.
>
> Best regards
>
> Benoît
Just one thing in general: You left my reviewed-by note on many patches
of the series although basically every single patch has changed (some
more, some less). This makes it harder for me to review (okay, not
really; I can (and should) still compare with the old versions for the
actual changes, but if I fail to do so...) and can cause some patches to
be merged because "I reviewed it" (although I actually didn't) -
probably not in this case since it's hard here to pick single patches to
merge, but well...
Max
next prev parent reply other threads:[~2014-02-15 1:12 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-12 22:06 [Qemu-devel] [PATCH V17 00/12] quorum block filter Benoît Canet
2014-02-12 22:06 ` [Qemu-devel] [PATCH V17 01/12] quorum: Create quorum.c, add QuorumChildRequest and QuorumAIOCB Benoît Canet
2014-02-15 1:17 ` Max Reitz
2014-02-12 22:06 ` [Qemu-devel] [PATCH V17 02/12] quorum: Create BDRVQuorumState and BlkDriver and do init Benoît Canet
2014-02-15 1:22 ` Max Reitz
2014-02-12 22:06 ` [Qemu-devel] [PATCH V17 03/12] quorum: Add quorum_aio_writev and its dependencies Benoît Canet
2014-02-15 1:31 ` Max Reitz
2014-02-12 22:06 ` [Qemu-devel] [PATCH V17 04/12] blkverify: Extract qemu_iovec_clone() and qemu_iovec_compare() from blkverify Benoît Canet
2014-02-15 1:36 ` Max Reitz
2014-02-12 22:06 ` [Qemu-devel] [PATCH V17 05/12] quorum: Add quorum_aio_readv Benoît Canet
2014-02-15 1:40 ` Max Reitz
2014-02-17 10:57 ` Kevin Wolf
2014-02-12 22:06 ` [Qemu-devel] [PATCH V17 06/12] quorum: Add quorum mechanism Benoît Canet
2014-02-15 1:53 ` Max Reitz
2014-02-12 22:06 ` [Qemu-devel] [PATCH V17 07/12] quorum: Add quorum_getlength() Benoît Canet
2014-02-12 22:06 ` [Qemu-devel] [PATCH V17 08/12] quorum: Add quorum_invalidate_cache() Benoît Canet
2014-02-12 22:06 ` [Qemu-devel] [PATCH V17 09/12] quorum: Add quorum_co_flush() Benoît Canet
2014-02-15 1:54 ` Max Reitz
2014-02-12 22:06 ` [Qemu-devel] [PATCH V17 10/12] quorum: Implement recursive .bdrv_recurse_is_first_non_filter in quorum Benoît Canet
2014-02-12 22:06 ` [Qemu-devel] [PATCH V17 11/12] quorum: Add quorum_open() and quorum_close() Benoît Canet
2014-02-13 9:09 ` Benoît Canet
2014-02-18 4:06 ` Fam Zheng
2014-02-18 12:31 ` Benoît Canet
2014-02-15 2:02 ` Max Reitz
2014-02-12 22:06 ` [Qemu-devel] [PATCH V17 12/12] quorum: Add unit test Benoît Canet
2014-02-15 1:15 ` Max Reitz [this message]
2014-02-15 2:04 ` [Qemu-devel] [PATCH V17 00/12] quorum block filter Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FEBF9A.3080500@redhat.com \
--to=mreitz@redhat.com \
--cc=benoit.canet@irqsave.net \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).