From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34505) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WEUZf-0007Rm-PP for qemu-devel@nongnu.org; Fri, 14 Feb 2014 21:01:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WEUZZ-00077q-Qt for qemu-devel@nongnu.org; Fri, 14 Feb 2014 21:01:47 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48383) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WEUZZ-00077l-Ie for qemu-devel@nongnu.org; Fri, 14 Feb 2014 21:01:41 -0500 Message-ID: <52FECB13.3090700@redhat.com> Date: Sat, 15 Feb 2014 03:04:03 +0100 From: Max Reitz MIME-Version: 1.0 References: <1392242799-16364-1-git-send-email-benoit.canet@irqsave.net> <52FEBF9A.3080500@redhat.com> In-Reply-To: <52FEBF9A.3080500@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH V17 00/12] quorum block filter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QmVub8OudCBDYW5ldA==?= , qemu-devel@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com, stefanha@redhat.com On 15.02.2014 02:15, Max Reitz wrote: > On 12.02.2014 23:06, Beno=C3=AEt Canet wrote: >> I post this for review in prevision of 2.0 feature freeze. >> Even if the series look correct please wait before merging because: >> >> The QMP events in the "Add quorum mechanism" definitively needs to be=20 >> reviewed >> by Eric as they where changed. >> >> I did not found any bugs while testing this version but I am willing=20 >> to test the >> code further before it's applied even it's reviewed by. >> >> Best regards >> >> Beno=C3=AEt > > Just one thing in general: You left my reviewed-by note on many=20 > patches of the series although basically every single patch has=20 > changed (some more, some less). This makes it harder for me to review=20 > (okay, not really; I can (and should) still compare with the old=20 > versions for the actual changes, but if I fail to do so...) and can=20 > cause some patches to be merged because "I reviewed it" (although I=20 > actually didn't) - probably not in this case since it's hard here to=20 > pick single patches to merge, but well... > > Max The reviewed-by for all the patches I didn't reply to (7, 8, 10, 12) is=20 okay and I'm hereby renewing it. Max