public inbox for qemu-devel@nongnu.org
 help / color / mirror / Atom feed
From: Shivang Upadhyay <shivangu@linux.ibm.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Nathan Chancellor <nathan@kernel.org>,
	qemu-ppc@nongnu.org, qemu-devel@nongnu.org, npiggin@gmail.com,
	milesg@linux.ibm.com, Aditya Gupta	 <adityag@linux.ibm.com>,
	Harsh Prateek Bora <harshpb@linux.ibm.com>,
	BALATON Zoltan <balaton@eik.bme.hu>,
	qemu-stable@nongnu.org
Subject: Re: [PATCH v2] ppc/pnv: fix dumpdtb option
Date: Tue, 24 Mar 2026 16:17:53 +0530	[thread overview]
Message-ID: <52b6a46d32483a51e666e9560662825a54101092.camel@linux.ibm.com> (raw)
In-Reply-To: <fc2985a0adfeb0de4bb2980798950f1ca2b0a4f7.camel@linux.ibm.com>

On Tue, 2026-03-24 at 15:51 +0530, Shivang Upadhyay wrote:
> On Tue, 2026-03-24 at 10:14 +0000, Peter Maydell wrote:
> > 
> > You might also consider using qemu_add_machine_init_done_notifier()
> > to register a callback that happens after machine-init is complete
> > (i.e. all command-line created devices have been completed): if
> > I understand correctly that would be a valid place to create the
> > DTB
> > (the machine-init-done hook is called after everything is created,
> > but before we process the dumpdtb option).
> 
> Ah, That would be a good direction. Thanks Ill check on this, and
> report.

I tried adding dt_create in qemu_add_machine_init_done_notifier hook,
and that Does fix the above case.

Thanks for the suggestion Peter. I should send a patch after the tests.

~Shivang.


      reply	other threads:[~2026-03-24 10:49 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-11 14:35 [PATCH v2] ppc/pnv: fix dumpdtb option Shivang Upadhyay
2026-03-11 14:57 ` Peter Maydell
2026-03-11 15:04   ` Shivang Upadhyay
2026-03-13  6:15 ` Aditya Gupta
2026-03-13  6:41   ` Aditya Gupta
2026-03-13 11:20 ` Aditya Gupta
2026-03-13 16:33   ` Shivang Upadhyay
2026-03-16  6:09   ` Shivang Upadhyay
2026-03-23 23:16 ` Nathan Chancellor
2026-03-24  6:30   ` Shivang Upadhyay
2026-03-24  8:42   ` Shivang Upadhyay
2026-03-24 10:14     ` Peter Maydell
2026-03-24 10:21       ` Shivang Upadhyay
2026-03-24 10:47         ` Shivang Upadhyay [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52b6a46d32483a51e666e9560662825a54101092.camel@linux.ibm.com \
    --to=shivangu@linux.ibm.com \
    --cc=adityag@linux.ibm.com \
    --cc=balaton@eik.bme.hu \
    --cc=harshpb@linux.ibm.com \
    --cc=milesg@linux.ibm.com \
    --cc=nathan@kernel.org \
    --cc=npiggin@gmail.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox