qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Robert Hoo <robert.hu@linux.intel.com>
To: mjt@tls.msk.ru, laurent@vivier.eu, qemu-trivial@nongnu.org
Cc: robert.hu@intel.com, qemu-devel@nongnu.org
Subject: Re: [Trivial] docs: More precisely describe memory-backend-*::id's user
Date: Sat, 01 May 2021 10:29:28 +0800	[thread overview]
Message-ID: <52be4506d86b899f185278373fc2e031000a7ab8.camel@linux.intel.com> (raw)
In-Reply-To: <1619080922-83527-1-git-send-email-robert.hu@linux.intel.com>

Ping for review ...
Thanks.

On Thu, 2021-04-22 at 16:42 +0800, Robert Hoo wrote:
> 'id' of memory-backend-{file,ram} is not only for '-numa''s
> reference, but
> also other parameters like '-device nvdimm'.
> More clearly call out this to avoid misinterpretation.
> 
> Signed-off-by: Robert Hoo <robert.hu@linux.intel.com>
> ---
>  qemu-options.hx | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/qemu-options.hx b/qemu-options.hx
> index fd21002..635dc8a 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -4508,11 +4508,11 @@ SRST
>          the guest RAM with huge pages.
>  
>          The ``id`` parameter is a unique ID that will be used to
> -        reference this memory region when configuring the ``-numa``
> -        argument.
> +        reference this memory region in other parameters, e.g. ``-
> numa``,
> +        ``-device nvdimm``, etc.
>  
>          The ``size`` option provides the size of the memory region,
> and
> -        accepts common suffixes, eg ``500M``.
> +        accepts common suffixes, e.g. ``500M``.
>  
>          The ``mem-path`` provides the path to either a shared memory
> or
>          huge page filesystem mount.



  reply	other threads:[~2021-05-01  2:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-22  8:42 [Trivial] docs: More precisely describe memory-backend-*::id's user Robert Hoo
2021-05-01  2:29 ` Robert Hoo [this message]
2021-05-01  5:50 ` Markus Armbruster
2021-05-01  9:58 ` Laurent Vivier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52be4506d86b899f185278373fc2e031000a7ab8.camel@linux.intel.com \
    --to=robert.hu@linux.intel.com \
    --cc=laurent@vivier.eu \
    --cc=mjt@tls.msk.ru \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=robert.hu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).