From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A6EBC433C1 for ; Mon, 22 Mar 2021 16:06:07 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BD933619B0 for ; Mon, 22 Mar 2021 16:06:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BD933619B0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57784 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lON49-0003ZO-L8 for qemu-devel@archiver.kernel.org; Mon, 22 Mar 2021 12:06:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43752) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lOMyy-0005ju-CU for qemu-devel@nongnu.org; Mon, 22 Mar 2021 12:00:44 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:47506) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lOMyr-0007ic-IX for qemu-devel@nongnu.org; Mon, 22 Mar 2021 12:00:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616428835; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/gNzf1Y2C35Lq5r+BuKpwFeQYXmsfxlgHRkAITtfA6A=; b=CZFRMFsoXXk46eNOyNsUphkVl6PnP7INg1V+nlMDJCcrHdWzT+uVXx2NlgxHzNZY4Sy9aN m3hySAyNSi1C8xz3n9yL/yuWAZi3B64cdn/5Cy/ojl8Uxhg4Vayj2i1chus202/otNSjE7 +cdS4aYFWBM+6db3zoicKQteV7jJqL4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-323-maa9E7kFMn-d5_7EWD4kNQ-1; Mon, 22 Mar 2021 12:00:32 -0400 X-MC-Unique: maa9E7kFMn-d5_7EWD4kNQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9901C102CB9B; Mon, 22 Mar 2021 16:00:30 +0000 (UTC) Received: from thuth.remote.csb (ovpn-112-79.ams2.redhat.com [10.36.112.79]) by smtp.corp.redhat.com (Postfix) with ESMTP id AA659610AF; Mon, 22 Mar 2021 16:00:24 +0000 (UTC) Subject: Re: [PATCH 1/5] tests: Use the normal yank code instead of stubs in relevant tests To: Lukas Straub References: <950007e82e19e75831b29fac07ab990c213d2352.1616368879.git.lukasstraub2@web.de> <1fc6eff2-a8e5-4ae2-96a5-1b30325dff81@redhat.com> <20210322083545.2c36b5a0@gecko.fritz.box> From: Thomas Huth Message-ID: <52d508d6-284c-6b36-62ed-f25081e63cfd@redhat.com> Date: Mon, 22 Mar 2021 17:00:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210322083545.2c36b5a0@gecko.fritz.box> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Marc-Andre Lureau , Li Zhang , qemu-devel , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 22/03/2021 08.35, Lukas Straub wrote: > On Mon, 22 Mar 2021 06:20:50 +0100 > Thomas Huth wrote: > >> On 22/03/2021 00.31, Lukas Straub wrote: >>> Use the normal yank code instead of stubs in relevant tests to >>> increase coverage and to ensure that registering and unregistering >>> of yank instances and functions is done correctly. >>> >>> Signed-off-by: Lukas Straub >>> --- >>> tests/qtest/meson.build | 6 +++--- >>> tests/unit/meson.build | 4 ++-- >>> 2 files changed, 5 insertions(+), 5 deletions(-) >>> >>> diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build >>> index 66ee9fbf45..40e1f495f7 100644 >>> --- a/tests/qtest/meson.build >>> +++ b/tests/qtest/meson.build >>> @@ -234,9 +234,9 @@ tpmemu_files = ['tpm-emu.c', 'tpm-util.c', 'tpm-tests.c'] >>> qtests = { >>> 'bios-tables-test': [io, 'boot-sector.c', 'acpi-utils.c', 'tpm-emu.c'], >>> 'cdrom-test': files('boot-sector.c'), >>> - 'dbus-vmstate-test': files('migration-helpers.c') + dbus_vmstate1, >>> + 'dbus-vmstate-test': ['migration-helpers.c', dbus_vmstate1, '../../monitor/yank.c'], >>> 'ivshmem-test': [rt, '../../contrib/ivshmem-server/ivshmem-server.c'], >>> - 'migration-test': files('migration-helpers.c'), >>> + 'migration-test': ['migration-helpers.c', io, '../../monitor/yank.c'], >>> 'pxe-test': files('boot-sector.c'), >>> 'qos-test': [chardev, io, qos_test_ss.apply(config_host, strict: false).sources()], >>> 'tpm-crb-swtpm-test': [io, tpmemu_files], >> >> Is this really necessary for the qtests? I can understand the change for the >> unit tests, but the qtests are separate programs where I could not imagine >> that they use the yank functions in any way? > > Yes, it is necessary. While the yank functions are not called in these tests, > it still checks that registering and unregistering of yank instances and > functions is done correctly. I.e. That no yank functions are registered before > the instance, that the yank instance is only unregistered after all functions > where unregistered, that the same instance is not registered twice and that > the yank instance actually exists before it is unregistered. Now you even confused me more. Could you elaborate a little bit? If none of the functions are called by the test, which part of yank.c is excercised here at all? Could you give a more detailed example? The only thing I could imagine is yank_init(), but that does not look like something we need to check in a qtest ? Thomas