Re: [Qemu-devel] [PULL 07/16] migration: Create x-multifd-page-count parameter

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1285 bytes --]

On 09/20/2017 05:46 AM, Juan Quintela wrote:
> Indicates how many pages we are going to send in each batch to a multifd
> thread.
> 
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Reviewed-by: Peter Xu <peterx@redhat.com>
> 

> +++ b/qapi/migration.json
> @@ -471,6 +471,9 @@
>  #                     number of sockets used for migration.  The
>  #                     default value is 2 (since 2.11)
>  #
> +# @x-multifd-page-count: Number of pages sent together to a thread
> +#                        The default value is 16 (since 2.11)

You're missing a '.' between sentences; it's more obvious when you no
longer have a newline between them when things are rendered to other
documentation formats.

Can be fixed as a followup.

> @@ -539,6 +542,9 @@
>  #                     number of sockets used for migration.  The
>  #                     default value is 2 (since 2.11)
>  #
> +# @x-multifd-page-count: Number of pages sent together to a thread
> +#                        The default value is 16 (since 2.11)
> +#

Multiple instances of it.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]