From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, silbe@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH RFC v3 1/5] tests: New make target check-source
Date: Thu, 30 Jun 2016 15:27:05 +0200 [thread overview]
Message-ID: <52f14da8-1ddc-fd17-2ddd-4eedddcec4e9@redhat.com> (raw)
In-Reply-To: <1467291213-13393-2-git-send-email-armbru@redhat.com>
On 30/06/2016 14:53, Markus Armbruster wrote:
> +bad-header-comment := /* FIXME Does not pass make check-headers$(bad-header-with-y), yet!
> +bad-headers := $(shell cd $(SRC_PATH) && fgrep -l '$(bad-header-comment)' $(src-headers))
> +bad-headers += $(shell fgrep -l '$(bad-header-comment)' $(gen-headers))
> +# Headers that require -DNEED_CPU_H etc.
> +target-header-comment := /* NOTE: May only be included into target-dependent code */
Perhaps accept a "FIXME" as well here? You don't have to use the right
one in the patch of course.
> diff --git a/target-sparc/cpu-qom.h b/target-sparc/cpu-qom.h
> index f63af72..30d112c 100644
> --- a/target-sparc/cpu-qom.h
> +++ b/target-sparc/cpu-qom.h
> @@ -17,6 +17,9 @@
> * License along with this library; if not, see
> * <http://www.gnu.org/licenses/lgpl-2.1.html>
> */
> +
> +/* NOTE: May only be included into target-dependent code */
This shouldn't be true for cpu-qom.h.
Perhaps
Paolo
> #ifndef QEMU_SPARC_CPU_QOM_H
> #define QEMU_SPARC_CPU_QOM_H
>
next prev parent reply other threads:[~2016-06-30 13:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-30 12:53 [Qemu-devel] [PATCH RFC v3 0/5] Baby steps towards saner headers Markus Armbruster
2016-06-30 12:53 ` [Qemu-devel] [PATCH RFC v3 1/5] tests: New make target check-source Markus Armbruster
2016-06-30 13:27 ` Paolo Bonzini [this message]
2016-06-30 14:30 ` Markus Armbruster
2016-06-30 14:31 ` Paolo Bonzini
2016-07-05 17:17 ` Sascha Silbe
2016-06-30 12:53 ` [Qemu-devel] [PATCH RFC v3 2/5] tests: Make check-block a phony target Markus Armbruster
2016-07-01 17:11 ` Eric Blake
2016-06-30 12:53 ` [Qemu-devel] [PATCH RFC v3 3/5] Include hw/irq.h where qemu_irq is used Markus Armbruster
2016-06-30 12:53 ` [Qemu-devel] [PATCH RFC v3 4/5] Include exec/hwaddr.h where hwaddr " Markus Armbruster
2016-06-30 12:53 ` [Qemu-devel] [PATCH RFC v3 5/5] Add a few missing #include "qemu/queue.h" Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52f14da8-1ddc-fd17-2ddd-4eedddcec4e9@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=silbe@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).